[freeipa PR#828][opened] Silence pytest.yield_fixture deprecation warning

[tiran]

   URL: https://github.com/freeipa/freeipa/pull/828
Author: tiran
 Title: #828: Silence pytest.yield_fixture deprecation warning
Action: opened

PR body:
"""
pytest >= 2.10 supports yield based fixtures with pytest.fixture. In
pytest < 2.10 pytest.yield_fixture is required. But that function
also raises a deprecation warning in pytest >= 3.0. FreeIPA has to stay
compatible with pytest < 2.10 for RHEL 7 testing.

https://docs.pytest.org/en/latest/fixture.html#fixture-finalization-execu...

https://pagure.io/freeipa/issue/6591

Signed-off-by: Christian Heimes <cheimes(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/828/head:pr828
git checkout pr828

[freeipa PR#828][+ack] Silence pytest.yield_fixture deprecation warning

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/828
Title: #828: Silence pytest.yield_fixture deprecation warning

Label: +ack

[freeipa PR#828][-ack] Silence pytest.yield_fixture deprecation warning

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/828
Title: #828: Silence pytest.yield_fixture deprecation warning

Label: -ack

[freeipa PR#828][comment] Silence pytest.yield_fixture deprecation warning

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/828
Title: #828: Silence pytest.yield_fixture deprecation warning

MartinBasti commented:
"""
I still see warnings from tox, it is expected with this patch?

```
/tmp/freeipa/.tox/py36/lib/python3.6/site-packages/ipatests/test_ipapython/test_ipautil.py
  yield tests are deprecated, and scheduled to be removed in pytest 4.0
  yield tests are deprecated, and scheduled to be removed in pytest 4.0
...
/tmp/freeipa/.tox/py36/lib/python3.6/site-packages/ipatests/test_ipapython/test_ssh.py
  yield tests are deprecated, and scheduled to be removed in pytest 4.0
  yield tests are deprecated, and scheduled to be removed in pytest 4.0
```
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/828#issuecomment-304805889

[freeipa PR#828][synchronized] Silence pytest.yield_fixture deprecation warning

[tiran]

   URL: https://github.com/freeipa/freeipa/pull/828
Author: tiran
 Title: #828: Silence pytest.yield_fixture deprecation warning
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/828/head:pr828
git checkout pr828

[freeipa PR#828][comment] Silence pytest.yield_fixture deprecation warning

[tiran]

  URL: https://github.com/freeipa/freeipa/pull/828
Title: #828: Silence pytest.yield_fixture deprecation warning

tiran commented:
"""
yield fixtures and yield tests are two different beasts. I have pushed another commit to
replace yield tests with parametrized tests.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/828#issuecomment-304812209

[freeipa PR#828][synchronized] Silence pytest.yield_fixture deprecation warning

[tiran]

   URL: https://github.com/freeipa/freeipa/pull/828
Author: tiran
 Title: #828: Silence pytest.yield_fixture deprecation warning
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/828/head:pr828
git checkout pr828

[freeipa PR#828][comment] Silence pytest.yield_fixture deprecation warning

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/828
Title: #828: Silence pytest.yield_fixture deprecation warning

MartinBasti commented:
"""
Thanks, it works
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/828#issuecomment-304835857

[freeipa PR#828][+ack] Silence pytest.yield_fixture deprecation warning

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/828
Title: #828: Silence pytest.yield_fixture deprecation warning

Label: +ack

[freeipa PR#828][comment] Silence pytest.yield_fixture deprecation warning

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/828
Title: #828: Silence pytest.yield_fixture deprecation warning

MartinBasti commented:
"""
master:

* af140b0bc15cf4c27c63cc88bc6eec792f29422a Silence pytest.yield_fixture deprecation
warning
* 090eadbe4e4d0ab9fe387c1966b51cdf28ed9b17 Reimplement yield tests are parametrized tests


"""

See the full comment at
https://github.com/freeipa/freeipa/pull/828#issuecomment-304838405

[freeipa PR#828][+pushed] Silence pytest.yield_fixture deprecation warning

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/828
Title: #828: Silence pytest.yield_fixture deprecation warning

Label: +pushed

[freeipa PR#828][closed] Silence pytest.yield_fixture deprecation warning

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/828
Author: tiran
 Title: #828: Silence pytest.yield_fixture deprecation warning
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/828/head:pr828
git checkout pr828