URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible recursion in RPC call from client Action: opened
PR body: """ This commit removes recursion which may lack end condition.
https://pagure.io/freeipa/issue/6796
=============================== This is my try to fix ^--. The methods and their arguments in the module are very poorly documented (they are not documented), so I just hope I can initialize the variables used in logs prior to the cycle.
I also think this actually relates more to https://pagure.io/freeipa/issue/6775 than the ticket mentioned here and that the person "fixing" https://pagure.io/freeipa/issue/6796 messed up the tickets but it's hopefully OK to fix it this way.
Aside from just moving everything into a cycle, I also improved logging a bit and had same error handling for different errors merged into one `except` block (`SSLError`, `socket.error`). """
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/818/head:pr818 git checkout pr818
URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible recursion in RPC call from client Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/818/head:pr818 git checkout pr818
URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible endless recursion in RPC call from client Action: edited
Changed field: title Original value: """ Avoid possible recursion in RPC call from client """
URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible endless recursion in RPC call from client Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/818/head:pr818 git checkout pr818
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client
flo-renaud commented: """ Hi @stlaz, thank you for the patch. The fix will avoid recursion in forward(), but I think that the same type of recursion could happen in create_connection().
"""
See the full comment at https://github.com/freeipa/freeipa/pull/818#issuecomment-304835378
URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible endless recursion in RPC call from client Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/818/head:pr818 git checkout pr818
URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible endless recursion in RPC call from client Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/818/head:pr818 git checkout pr818
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client
stlaz commented: """ Thanks for the good catch, @flo-renaud. While the recursion in the `forward()` method was quite easy to fix, it was not so in the `create_connection()`. I tried to do several improvements to the code on the way and I am submitting it to testing here. """
See the full comment at https://github.com/freeipa/freeipa/pull/818#issuecomment-305412672
URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible endless recursion in RPC call from client Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/818/head:pr818 git checkout pr818
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client
stlaz commented: """ The tests passed, I am just adding a minor comment typo fixup. """
See the full comment at https://github.com/freeipa/freeipa/pull/818#issuecomment-305423742
URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible endless recursion in RPC call from client Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/818/head:pr818 git checkout pr818
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client
flo-renaud commented: """ Hi @stlaz Thank you, the patch looks good to me. """
See the full comment at https://github.com/freeipa/freeipa/pull/818#issuecomment-305470664
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client
Label: +ack
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client
Label: +pushed
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client
MartinBasti commented: """ master:
* 81a808caeb5676427610e113b5a259511c2835d6 Avoid possible endless recursion in RPC call * 79d1752577e8fcb568b701509fe5b52f949d5e4b rpc: preparations for recursion fix * e1f8684e858b4ae47b54acd0d76a844bc20ce443 rpc: avoid possible recursion in create_connection
ipa-4-5:
* a5b413b72e224120acde09d1c877be11b3f61b6b Avoid possible endless recursion in RPC call * d8aab383a39a22cc613cf64e5d66ce69111d97df rpc: preparations for recursion fix * cb6c93dad044c724ba2cedbff49bf71aea939418 rpc: avoid possible recursion in create_connection
"""
See the full comment at https://github.com/freeipa/freeipa/pull/818#issuecomment-305808729
URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible endless recursion in RPC call from client Action: closed
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/818/head:pr818 git checkout pr818
freeipa-devel@lists.fedorahosted.org
-
flo-renaud -
MartinBasti
-
stlaz