Re: [freeipa/freeipa] Removing part of circular dependency of ipalib in ipaplatform (#989)

[Christian Heimes]

On 2017-08-23 21:25, Felipe Volpone wrote:
> @felipevolpone https://github.com/felipevolpone pushed 1 commit.
> 2ddaa6e https://github.com/freeipa/freeipa/commit/2ddaa6e Removing
> part of circular dependency of ipalib in ipaplaform

Why did you remove os.path.basename() from systemd-tmpfiles call? My
example included it on purpose. The tool does the right thing and
locates the correct config file on its own. A basename takes
customization into account, too.

Christian

[freeipa/freeipa] Removing part of circular dependency of ipalib in ipaplatform (#989)

[Felipe Barreto Volpone]

I removed os.path.basename() to check if that would
affect the tests. For some reason they're failing and
I'm not being able to reproduce it outside of travis/pr ci.

On Thu, Aug 24, 2017 at 4:17 AM, Christian Heimes 
wrote:
> On 2017-08-23 21:25, Felipe Volpone wrote:
> > @felipevolpone https://github.com/felipevolpone pushed 1 commit.
> > 2ddaa6e https://github.com/freeipa/freeipa/commit/2ddaa6e Removing
> > part of circular dependency of ipalib in ipaplaform
>
> Why did you remove os.path.basename() from systemd-tmpfiles call? My
> example included it on purpose. The tool does the right thing and
> locates the correct config file on its own. A basename takes
> customization into account, too.
>
> Christian
>
> --
> Christian Heimes
> Senior Software Engineer, Identity Management and Platform Security
>
> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
> Commercial register: Amtsgericht Muenchen, HRB 153243,
> Managing Directors: Charles Cachera, Michael Cunningham, Michael
> O'Neill, Eric Shander