URL:
https://github.com/freeipa/freeipa/pull/812
Title: #812: Refactoring cert-find to use API call directly instead of using
stlaz commented:
"""
```
************* Module ipaserver.plugins.cert
ipaserver/plugins/cert.py:1505: [C0303(trailing-whitespace), ] Trailing whitespace)
ipaserver/plugins/cert.py:1506: [W0312(mixed-indentation), ] Found indentation with tabs
instead of spaces)
ipaserver/plugins/cert.py:1508: [C0303(trailing-whitespace), ] Trailing whitespace)
ipaserver/plugins/cert.py:1512: [C0303(trailing-whitespace), ] Trailing whitespace)
ipaserver/plugins/cert.py:1513: [W0312(mixed-indentation), ] Found indentation with tabs
instead of spaces)
ipaserver/plugins/cert.py:1514: [W0312(mixed-indentation), ] Found indentation with tabs
instead of spaces)
ipaserver/plugins/cert.py:1515: [W0312(mixed-indentation), ] Found indentation with tabs
instead of spaces)
ipaserver/plugins/cert.py:1516: [W0312(mixed-indentation), ] Found indentation with tabs
instead of spaces)
ipaserver/plugins/cert.py:1517: [W0312(mixed-indentation), ] Found indentation with tabs
instead of spaces)
ipaserver/plugins/cert.py:1519: [W0312(mixed-indentation), ] Found indentation with tabs
instead of spaces)
ipaserver/plugins/cert.py:1520: [W0312(mixed-indentation), ] Found indentation with tabs
instead of spaces)
ipaserver/plugins/cert.py:1516: [E1101(no-member), cert_find._service_search] Instance of
'cert_find' has no '_get_cert_obj' member)
ipaserver/plugins/cert.py:1516: [E0602(undefined-variable), cert_find._service_search]
Undefined variable 'raw')
ipaserver/plugins/cert.py:1504: [W0612(unused-variable), cert_find._service_search] Unused
variable 'ldap')
```
```
PEP-8 errors:
./ipaserver/plugins/cert.py:1505:1: W293 blank line contains whitespace
./ipaserver/plugins/cert.py:1506:1: E101 indentation contains mixed spaces and tabs
./ipaserver/plugins/cert.py:1506:1: W191 indentation contains tabs
./ipaserver/plugins/cert.py:1507:1: E101 indentation contains mixed spaces and tabs
./ipaserver/plugins/cert.py:1508:1: W293 blank line contains whitespace
./ipaserver/plugins/cert.py:1512:1: W293 blank line contains whitespace
./ipaserver/plugins/cert.py:1513:1: E101 indentation contains mixed spaces and tabs
./ipaserver/plugins/cert.py:1513:1: W191 indentation contains tabs
./ipaserver/plugins/cert.py:1514:1: W191 indentation contains tabs
./ipaserver/plugins/cert.py:1514:2: E101 indentation contains mixed spaces and tabs
./ipaserver/plugins/cert.py:1515:1: W191 indentation contains tabs
./ipaserver/plugins/cert.py:1515:2: E101 indentation contains mixed spaces and tabs
./ipaserver/plugins/cert.py:1516:1: W191 indentation contains tabs
./ipaserver/plugins/cert.py:1516:2: E101 indentation contains mixed spaces and tabs
./ipaserver/plugins/cert.py:1517:1: W191 indentation contains tabs
./ipaserver/plugins/cert.py:1517:2: E101 indentation contains mixed spaces and tabs
./ipaserver/plugins/cert.py:1519:1: W191 indentation contains tabs
./ipaserver/plugins/cert.py:1519:2: E101 indentation contains mixed spaces and tabs
./ipaserver/plugins/cert.py:1520:1: W191 indentation contains tabs
```
https://i.imgflip.com/1pol0g.jpg
This does not even compile.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/812#issuecomment-303937715