URL: https://github.com/freeipa/freeipa/pull/853 Author: stlaz Title: #853: x509,certdb: handle certificates as bytes Action: opened
PR body: """ Certificates, both in PEM and DER format, should be handled as bytes in Python 3.
https://pagure.io/freeipa/issue/4985 ================================= This PR unblocks IPA with **external CA** installation under Python 3. """
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/853/head:pr853 git checkout pr853
URL: https://github.com/freeipa/freeipa/pull/853 Title: #853: x509,certdb: handle certificates as bytes
Label: +py3
URL: https://github.com/freeipa/freeipa/pull/853 Author: stlaz Title: #853: x509,certdb: handle certificates as bytes Action: edited
Changed field: body Original value: """ Certificates, both in PEM and DER format, should be handled as bytes in Python 3.
https://pagure.io/freeipa/issue/4985 ================================= This PR unblocks IPA with **external CA** installation under Python 3. """
URL: https://github.com/freeipa/freeipa/pull/853 Title: #853: x509,certdb: handle certificates as bytes
stlaz commented: """ To test this, you can use the script I provided at https://github.com/freeipa/freeipa-tools/pull/48, you just have to add `python3 ` before the `ipa-server-install` commands. """
See the full comment at https://github.com/freeipa/freeipa/pull/853#issuecomment-306394902
URL: https://github.com/freeipa/freeipa/pull/853 Author: stlaz Title: #853: x509,certdb: handle certificates as bytes Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/853/head:pr853 git checkout pr853
URL: https://github.com/freeipa/freeipa/pull/853 Title: #853: x509,certdb: handle certificates as bytes
Label: +WIP
URL: https://github.com/freeipa/freeipa/pull/853 Title: #853: x509,certdb: handle certificates as bytes
stlaz commented: """ This will require some more refactoring, adding WIP label.
Basically, `Bytes` parameter only base64-decodes its value if it's of `unicode`/`str` instance (Python2/Python3), but in most cases, its value is checked with `validate_ceritifate()` of the `ipaserver.plugins.service` module, which requires the certificate to be in DER format. But the ceritificate won't be decoded to DER from PEM as it above decoding condition is not fulfilled. """
See the full comment at https://github.com/freeipa/freeipa/pull/853#issuecomment-306514713
URL: https://github.com/freeipa/freeipa/pull/853 Author: stlaz Title: #853: x509,certdb: handle certificates as bytes Action: synchronized
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/853/head:pr853 git checkout pr853
URL: https://github.com/freeipa/freeipa/pull/853 Title: #853: x509,certdb: handle certificates as bytes
stlaz commented: """ Added a potential fixup to the tests to see whether they'd pass. It's not supposed to be pushed since it either proves that this PR should be worked on more thoroughly. """
See the full comment at https://github.com/freeipa/freeipa/pull/853#issuecomment-306724942
URL: https://github.com/freeipa/freeipa/pull/853 Title: #853: x509,certdb: handle certificates as bytes
stlaz commented: """ Added a potential fixup to the tests to see whether they'd pass. It's not supposed to be pushed since it either proves that this PR should be worked on more thoroughly. """
See the full comment at https://github.com/freeipa/freeipa/pull/853#issuecomment-306724942
URL: https://github.com/freeipa/freeipa/pull/853 Author: stlaz Title: #853: x509,certdb: handle certificates as bytes Action: closed
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/853/head:pr853 git checkout pr853
freeipa-devel@lists.fedorahosted.org
-
stlaz