Camera view for scanning QR code is upside down

[Dan Liew]

Hi,

I just installed FreeOTP (version 1.5) and I thought I'd let you know
there's a minor issue with the Camera view used for scanning QR codes.

On my device (Nexus 6p running Android 6.0) the camera view is upside
down. On my old device (Nexus 4) the camera view is the right way up
so I'm guessing its either an issue with Android 6.0 or specific to
the Nexus6p.

Thanks,
Dan.

[Anisse Astier]

Hi Dan,

I can confirm the issue on Nexus 6P. It doesn't prevent scanning QR
codes, but is a bit annoying.

To be precise, it's a 180 rotation of the camera view, not a flip.

Regards,

Anisse


On Sun, Nov 8, 2015 at 10:12 AM, Dan Liew <dan(a)su-root.co.uk&gt; wrote:
> Hi,
>
> I just installed FreeOTP (version 1.5) and I thought I'd let you know
> there's a minor issue with the Camera view used for scanning QR codes.
>
> On my device (Nexus 6p running Android 6.0) the camera view is upside
> down. On my old device (Nexus 4) the camera view is the right way up
> so I'm guessing its either an issue with Android 6.0 or specific to
> the Nexus6p.
>
> Thanks,
> Dan.
> _______________________________________________
> freeotp-devel mailing list
> freeotp-devel(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/freeotp-devel

[Nathaniel McCallum]

On Sun, 2015-11-08 at 09:12 +0000, Dan Liew wrote:
>  Hi,
>  
>  I just installed FreeOTP (version 1.5) and I thought I'd let you know
>  there's a minor issue with the Camera view used for scanning QR
>  codes.
>  
>  On my device (Nexus 6p running Android 6.0) the camera view is upside
>  down. On my old device (Nexus 4) the camera view is the right way up
>  so I'm guessing its either an issue with Android 6.0 or specific to
>  the Nexus6p. 
This is actually a bug in the Android API which required them to move
to the camera2 API. We don't yet support this API, but will be moving
to it in the next release. That is to say, we are aware of the issue
and have plans to fix it.

Nathaniel

Hi all,

I run into the same issue with my Nexus 5x. This problem actually can be addressed without
upgrading to camera2 API (See
https://www.reddit.com/r/Android/comments/3rjbo8/nexus5x_marshmallow_came... for
details on how to do this with the old camera API).

I checked freeotp sources and it already contains the suggested workaround code! I could
not understand why I can see the picture upside down even though the code is already in
freeotp until I found a bug in a different part of ScanningActivity. 

On my Nexus 5x, this bug causes the ScanningActivity to read and use properties (such as
orientation) of the front camera although it is the rear camera that is actually used for
preview and scanning. As a result, orientation is not properly calculated.

The fix is really simple and can be found here:
https://github.com/jharting/freeotp/commit/38ee3292fc8366b4cf329d3c08b301...

[Nathaniel McCallum]

Fantastic! I'll merge this later today after some testing.

----- Original Message -----
> Hi all,
> 
> I run into the same issue with my Nexus 5x. This problem actually can be
> addressed without upgrading to camera2 API (See
> https://www.reddit.com/r/Android/comments/3rjbo8/nexus5x_marshmallow_came...
> for details on how to do this with the old camera API).
> 
> I checked freeotp sources and it already contains the suggested workaround
> code! I could not understand why I can see the picture upside down even
> though the code is already in freeotp until I found a bug in a different
> part of ScanningActivity.
> 
> On my Nexus 5x, this bug causes the ScanningActivity to read and use
> properties (such as orientation) of the front camera although it is the rear
> camera that is actually used for preview and scanning. As a result,
> orientation is not properly calculated.
> 
> The fix is really simple and can be found here:
> https://github.com/jharting/freeotp/commit/38ee3292fc8366b4cf329d3c08b301...
> _______________________________________________
> freeotp-devel mailing list
> freeotp-devel(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/admin/lists/[e-mail]...
>