token images

[Ryan Sawhill Aroha]

So thanks to the new version, I've got the capability for logos on my 
tokens now. Awesome.

A few thoughts:

1. I've got what seems to be a bug with the new version on my Nexus 7. 
Adding a new token via scanning a QR code works, but there's no feedback 
to let me know that it works. The scanner just keeps turning and trying 
to focus etc until I hit back. Once I do, I can see that there's 
actually a new token. Fully reproduceable with github, which used to 
work fine (old version). Haven't tried any other sites yet.

2. What are recommended sizes for images? How are non-square images handled?

3. Where did the devs get the logos used in the new screenshots in the 
google app store? I'm having a hard time finding square logo-only images 
online to use for this purpose (without editing). Perhaps we could have 
an online repository for user-contributed images (hmmm... copyright ...) 
that FreeOTP could connect to.

4. The image stretches to the very edge of each token widget/card (for 
lack of a better word). From a UX perspective, I think it would be 
better to force a border around it (meaning: the image will be a little 
smaller).

Thanks!

[Nathaniel McCallum]

On Wed, 2014-08-27 at 09:07 -0400, Ryan Sawhill Aroha wrote:
> So thanks to the new version, I've got the capability for logos on my 
> tokens now. Awesome.
>
> A few thoughts:
> I've got what seems to be a bug with the new version on my Nexus 7.
>
> Adding a new token via scanning a QR code works, but there's no feedback 
> to let me know that it works. The scanner just keeps turning and trying 
> to focus etc until I hit back. Once I do, I can see that there's 
> actually a new token. Fully reproduceable with github, which used to 
> work fine (old version). Haven't tried any other sites yet.

I have a Nexus 7 (2013). I'm charging it now and will test it in a bit.
> What are recommended sizes for images? How are non-square images handled?

This is currently (and intentionally) undocumented. My plan is to get
image provisioning support on iOS and then come up with some documented
best practices. At this time I would (unofficially!) recommend 512x512
or higher. This is because, on Android, the size is 96dip. On higher
density screens, this number is multiplied to come up with the actual
pixel size. For instance, on xxxhdpi, the size is 384x384. On iOS,
things are handled slightly differently. I need to come up a with a
workable set of recommendations.
> Where did the devs get the logos used in the new screenshots in the
>
> google app store? I'm having a hard time finding square logo-only images 
> online to use for this purpose (without editing). Perhaps we could have 
> an online repository for user-contributed images (hmmm... copyright ...) 
> that FreeOTP could connect to.

You might try googling "square $COMPANY logo" or other similar things.

An online repository is unfortunately a bad idea for lots of reasons,
but especially for copyright. However, by defining a standard parameter
in the token URI, providers can embed links to their own images in QR
codes. I think this is preferred (and is the very reason for the new
internet permission).
> The image stretches to the very edge of each token widget/card (for
>
> lack of a better word). From a UX perspective, I think it would be 
> better to force a border around it (meaning: the image will be a little 
> smaller).

This actually follows Android's Material Design guidelines. We are
gradually moving toward Material Design without losing support for pre-L
Android versions.

[Ryan Sawhill Aroha]

On 08/27/2014 11:07 AM, Nathaniel McCallum wrote:
> On Wed, 2014-08-27 at 09:07 -0400, Ryan Sawhill Aroha wrote:
> > I've got what seems to be a bug with the new version on my Nexus 7.
> >
> > Adding a new token via scanning a QR code works, but there's no feedback
> > to let me know that it works. The scanner just keeps turning and trying
> > to focus etc until I hit back. Once I do, I can see that there's
> > actually a new token. Fully reproduceable with github, which used to
> > work fine (old version). Haven't tried any other sites yet.
>
> I have a Nexus 7 (2013). I'm charging it now and will test it in a bit.

I confirmed this with another website today (Evernote). Same behavior 
(had to manually press back to go away from camera but when I did the 
new token was there).
> > What are recommended sizes for images? How are non-square images handled?
>
> This is currently (and intentionally) undocumented. My plan is to get
> image provisioning support on iOS and then come up with some documented
> best practices. At this time I would (unofficially!) recommend 512x512
> or higher. This is because, on Android, the size is 96dip. On higher
> density screens, this number is multiplied to come up with the actual
> pixel size. For instance, on xxxhdpi, the size is 384x384.

Good to know!
> You might try googling "square $COMPANY logo" or other similar things.
>
> An online repository is unfortunately a bad idea for lots of reasons,
> but especially for copyright. However, by defining a standard parameter
> in the token URI, providers can embed links to their own images in QR
> codes. I think this is preferred (and is the very reason for the new
> internet permission).

Yeah I had been having a rough time finding good ones with google, but I 
had much more luck once I started using google's advanced search 
settings to configure the type as "clip art", the aspect ratio as 
square, and the filetype as png.
> > The image stretches to the very edge of each token widget/card (for
> >
> > lack of a better word). From a UX perspective, I think it would be
> > better to force a border around it (meaning: the image will be a little
> > smaller).
>
> This actually follows Android's Material Design guidelines. We are
> gradually moving toward Material Design without losing support for pre-L
> Android versions.

Okay. If you say so! :)

[Nathaniel McCallum]

On Aug 27, 2014, at 11:07 AM, Nathaniel McCallum  wrote:
> On Wed, 2014-08-27 at 09:07 -0400, Ryan Sawhill Aroha wrote:
> > So thanks to the new version, I've got the capability for logos on my 
> > tokens now. Awesome.
> >
> > A few thoughts:
> > I've got what seems to be a bug with the new version on my Nexus 7.
> >
> > Adding a new token via scanning a QR code works, but there's no feedback 
> > to let me know that it works. The scanner just keeps turning and trying 
> > to focus etc until I hit back. Once I do, I can see that there's 
> > actually a new token. Fully reproduceable with github, which used to 
> > work fine (old version). Haven't tried any other sites yet.
>
> I have a Nexus 7 (2013). I'm charging it now and will test it in a bit.

I was able to reproduce this. I committed a fix here: https://fedorahosted.org/freeotp/changeset/ef9a61881edf789121d37854739ad21a7...

I have also pushed a new release to Google Play as I considered this an urgent issue.

Nathaniel