func September 2012

func@lists.fedorahosted.org

1 participants
3 discussions

Changes to copyfile functionality.
by Marcus Lauer 30 Sep '12

30 Sep '12

It seems to me that there are at least three improvements which should be made to copyfile: 1. If the file on the overlord and minion are the same, that file should not be copied. This saves bandwidth/processing time. 2. Overwriting the file on the minion should be atomic, e.g. the file on the overlord should be copied to a tempfile on the minion then moved to overwrite the target file as a final step. Right now if funcd dies or something goes wrong mid-copy you end up with half a file on the minion. 3. There should be an option (off by default) such that if the file which has been copied over to the minion is not identical to the file on the overlord it is re-copied, or at least does not overwrite the file on the minion. This won't work for some files (busy logfiles) but for most files it seems like an extra bit of reliability which most people would want in most situations. I submitted a patch (though not a git-patch... my bad!) back in January 2011 which implements #1, but imperfectly. The overlord still has to send a (small) packet to the minion for each 60KB chunk of target file. Would anyone be bothered terribly if I worked on #2 and #3? While I am at it I will try to find a way to fix up my patch for #1 as well. There is some overlap between these patches. Both will involve calculating an MD5 hash of the file on the overlord, for example. P.S. Is the new mailing list on fedorahosted.org live yet? I am sending this message to both just in case. -- Marcus

2 6

PATCH: Remove old "copyfile" method from copyfile minion code
by Marcus Lauer 13 Sep '12

13 Sep '12

It appears that once upon a time the act of copying a file involved reading a file into memory and passing all of that data to a single method on the minion side. That method was called "copyfile". For some reason this method still exists even though it is unused. This patch removes that method. Note that there are several other bits of code in copyfile which are currently unused including the "checksum", "_checksum_blob" and "_backuplocal" methods on the minion side and code supporting the "--force" option in the cmd_module. I think that all of these could be useful in the future which is why I decided not to remove them. -- Marcus

1 0

PATCH: Improve help info for copyfile
by Marcus Lauer 13 Sep '12

13 Sep '12

For some reason the command-line arguments for copyfile can only be found online or in the source code. They are not part of the "usage" info, which is literally just a string defined in the copyfile command module. This patch makes that string a little more useful, as follows: [root@centos1 ~]# func '*' copyfile Usage: func [--options] "hostname glob" module method [arg1] [arg2] ... func [--options] "hostname glob" module method [arg1] [arg2] ... copyfile -f localfile --remotepath /remotepath/filename localfile = the file on the overlord to copy /remotepath/filename = the full path for the copied file on the minion This patch changes one line of code. :) -- Marcus

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

func September 2012