Hi,
Quick ping, and updated glibc.spec patch.
On Wed, 2017-07-12 at 14:46 +0200, Stef Walter wrote:
On 07.07.2017 10:59, Mark Wielaard wrote:
Some recent glibc hardening updates broke valgrind on arm32. The fix was easy, but it could have been caught earlier. I have CCed Stef Walter since he is the contact for https://fedoraproject.org/wiki/CI and they might have ideas for a better way to do this (see below).
But for now I would suggest the following patch for the glibc.spec file:
diff --git a/glibc.spec b/glibc.spec index 5e8486a..ecb41c0 100644 --- a/glibc.spec +++ b/glibc.spec @@ -2042,7 +2042,8 @@ pushd build-%{target} LD_SHOW_AUXV=1 elf/ld.so --library-path .:elf:nptl:dlfcn /bin/true
%if %{with valgrind} -elf/ld.so --library-path .:elf:nptl:dlfcn /usr/bin/valgrind \ +elf/ld.so --library-path .:elf:nptl:dlfcn \
/usr/bin/valgrind --error-exitcode=1 \ elf/ld.so --library-path .:elf:nptl:dlfcn /usr/bin/true
%endif popd
That makes sure that not only is valgrind run on /bin/true, but also that no errors are produced by valgrind. There really should be none for /bin/true, if there are any that would mean such error/warnings would show up for each and every program run under valgrind, and that is really just noise.
I put something similar in the valgrind.spec file and it passes on all rawhide arches. [...] Putting the test in the spec file %check of the packages is really helpful. But maybe it would be more helpful if such a check could be run on a new compose on all architectures whenever one of these packages is updated by the new Fedora CI initiative. Currently only glibc and valgrind have this cross check, updates to gcc or the kernel are only caught later when glibc or valgrind are rebuild.
Indeed. I agree that %check is a good place to start.
Could someone apply the attached patch to the glibc.spec to have this. (Also included a change for the valgrind BuildRequires from file based to package based.)
Thanks,
Mark