Team,
We have had some cleanup requests here:
https://bugzilla.redhat.com/show_bug.cgi?id=1476839
0001-release-31.patch
- Bumps NEVRA.
- Removes some %if'ing.
I am rejecting patch #1 outright, the %if'ing I find a matter of taste.
The NEVRA change always happens anyway.
So patch #1 rejected.
0002-remove-Group-and-defatr-o~cial-Fedora-Packaging-Po.patch
- Removes Group tag, and %defattr directive where it wouldn't make a difference.
The removal of the Group tag is OK.
I'm rejecting the removal of the %defattr because I don't have the time to
verify.
However, I noticed a few additional Fedora Packaging Guidline issues:
- We should remove %clean.
- We should not rm -rf $RPM_BUILD_ROOT in %install.
- We shoudl not use BuildRoot tag (why are we using this?)
So I've added those to the final patch too, after doing slightly smarter filelist
file cleanups.
0003-remove-in-files-redundant~nfig-missingok-noreplace.patch
- Remove specific %config and %verify in the presence of %ghost.
I'm rejecting this patch because it relies on what appears to be implementation
dependent behaviour of %ghost, specifically that it ignores certain changes.
While it seems logical that %ghost should ignore certain changes I would rather
leave the belt-and-suspenders check with %verify, and %config.
0004-added-execute-sbin-ldcofi~n-transfiletriggerin-and.patch
- Discussion moved to
https://bugzilla.redhat.com/show_bug.cgi?id=1380878
WIP patch is attached. Build in progress.
Thoughts on the changes?
Seems sensible to me and aligns better with Fedora Packaging Guidelines.
--
Cheers,
Carlos.