Re: F28 System Wide Change: Golang 1.10a

[Jakub Cajka]

----- Original Message -----
> From: "nicolas mailhot" 
> To: [e-mail]
> Sent: Monday, January 15, 2018 2:48:36 PM
> Subject: Re: F28 System Wide Change: Golang 1.10a
>
> De: "Jakub Cajka"
> > Have you investigated the build failures to have such strong claim?
>
> I, obviously hadn't have the time to investigate each failure
>
> However, given the builds ran in parallel on the same computer, pointing to
> the same repositories (with the exception of Go 1.9 forcing in one case),
> and a large part of the spec stash completely replaces the Fedora Go package
> baseline with up to date code (often the upstream last commit or release)
> that actually runs unit tests I'm pretty sure you can not blame the failures
> on outdated packages.

I'm not generally blaming it on outdated packages(although there are some), I'm mostly blaming it on code that is not following best coding practices(https://tip.golang.org/doc/go1.10#test) or assume some not guaranteed/universal assumptions.
> On the contrary I suspect some of the packages that pass in your tests are
> obsolete code with disabled unit tests so you're not seeing all the
> problems.

Can you back it up it? Or is it just your assumption? Actually most of the failures approx 70% is occurring in tests(see up mentioned link).

JC
> Regards,
>
> Nicolas Mailhot
> _______________________________________________
> golang mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]