On Wed Dec 20, 2023 at 12:14 +0100, Ondrej Pohorelsky wrote:
On Tue, Dec 19, 2023 at 11:11 PM Neal Gompa ngompa13@gmail.com wrote:
On Tue, Dec 19, 2023 at 4:14 PM Brad Smith bradley.g.smith@gmail.com wrote:
At a minimum, I recommend that the patch include the original values for GOPROXY, GOSUMDB, and GOTOOLCHAIN as comments. This makes it easier to change back to default values. At the moment, one has to visit the relevant web pages.
I lean towards providing upstream defaults in this case with updated content on the developer portal (and elsewhere?) with information on why changing these values would be useful. I agree that the comments in the thread are persuasive (for me).
I agree with this. I'd rather keep the patch than revert to upstream defaults.
<snip>
If you decide to keep the envars as they are now, I would also agree with having the original values commented.
Can someone clarify what they mean by this? The patch itself [1] makes it pretty clear what the original values are. I think the main thing is improving the user-facing documentation about why we do this and how to restore the original behavior. The Fedora Developer Portal (which really needs to be promoted more; it's a great resource!) documents [2] that we change GOPROXY and GOTOOLCHAIN, but it doesn't mention GOSUMDB, and it's lacking clear instructions about how to change the values back to defaults.
[1]: https://src.fedoraproject.org/rpms/golang/blob/rawhide/f/0001-Modify-go.env.... [2]: https://developer.fedoraproject.org/tech/languages/go/go-installation.html#f...