On 12/11/2017 12:51 PM, nicolas.mailhot(a)laposte.net wrote:
De: "Panu Matilainen"
> Kudos for work on reducing repetitive complex error prone cruft in specs!
> But don't override %setup. There's no need for such abuse
It is really pretty safe, the macro controls the downloaded file, the file structure is
known, the only time it won't "just work" is when a spec needs to call
%setup several times (in that case the arguments will be wrong for the second call).
No. It's not about whether it's "pretty safe" or not, it's an
built-in and it's simply not yours to override (and what about the next
guy who wants to override it for their own purposes, say, go-specific
thing?). The fact that you can do so is basically a loophole in rpm that
just hasn't gotten closed, yet. Don't bet the future on loopholes.
- Panu -