[Bug 1166312] New: etcd unit should support command line options

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1166312

            Bug ID: 1166312
           Summary: etcd unit should support command line options
           Product: Fedora
           Version: 21
         Component: etcd
          Assignee: lacypret(a)gmail.com
          Reporter: lars(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: eparis(a)redhat.com, golang(a)lists.fedoraproject.org,
                    jchaloup(a)redhat.com, lacypret(a)gmail.com,
                    lemenkov(a)gmail.com



The "etcd.service" unit distributed with Fedora 21 (atomic) does not contain
any facilities for passing arguments to etcd.  That is, it looks like this:

[Service]
Type=simple
StandardOutput=null
WorkingDirectory=/var/lib/etcd
User=etcd
ExecStart=/usr/bin/etcd

This means that if a deployer wants to pass arguments to etcd at boot (such as
a discovery URL), the only option is to introduce a new unit file in
/etc/systemd/system.

This works, but it seems like a heavy hammer.

It seems as if a better choice would be to introduce an EnvironmentFile
directive like we do for so many other units.  Something like:

[Service]
Type=simple
StandardOutput=null
WorkingDirectory=/var/lib/etcd
User=etcd
EnvironmentFile=/etc/sysconfig/etcd
ExecStart=/usr/bin/etcd $OPTIONS

-- 
You are receiving this mail because:
You are on the CC list for the bug.