Greetings -
On Wed, Dec 20, 2023 at 7:35 AM Maxwell G maxwell@gtmx.me wrote:
Can someone clarify what they mean by this? The patch itself [1] makes it pretty clear what the original values are.
When I look at /usr/lib/golang/go.env I see:
---- [bgsmith@pico newversionprep (main *%)]$ more /usr/lib/golang/go.env # This file contains the initial defaults for go command configuration. # Values set by 'go env -w' and written to the user's go/env file override these. # The environment overrides everything else.
# Use the Go module mirror and checksum database by default. # See https://proxy.golang.org for details. GOPROXY=proxy.golang.org,direct GOSUMDB=sum.golang.org
# Automatically download newer toolchains as directed by go.mod files. # See https://go.dev/doc/toolchain for details. GOTOOLCHAIN=auto ------
The go.env file does not, as far as I can tell, contain the original values from upstream. Just the modified values. Unless I modified the file and cannot recall doing so! My suggestion was to include the original upstream settings as comments.
improving the user-facing documentation about why we do this and how to restore the original behavior. The Fedora Developer Portal (which really needs to be promoted more; it's a great resource!) documents [2] that we change GOPROXY and GOTOOLCHAIN, but it doesn't mention GOSUMDB, and it's lacking clear instructions about how to change the values back to defaults.
The updates to this developer portal page with gosumdb were made last month but there has been a delay in publishing to production. Should show up any day.
best regards