linkdupont commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you are following: ``
I'm actually confused why `%gobuildflags` exists, because `%gobuild` below that doesn't use it. In fact, `%gobuild` uses an exact copy of `gobuildflags` with `BUILDTAGS` _already_ there.
I guess `gobuildflags` is there if you need to somehow call `go build` manually? But in that case adding `BUILDTAGS` to `gobuildflags` is only halfway to making things consistent. `gobuild` should also be changed to _use_ `gobuildflags`, or things will fall out of sync again.
This does look like an optimization that could be made to tidy up the macro a bit. Feel free to PR this if you feel like it's a good idea. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/34