[go-rpm-macros] PR #35: fix(macros): use gobuildflags macro in %gobuild
linkdupont commented on the pull-request: `fix(macros): use gobuildflags macro in
%gobuild` that you are following:
``
I think this helps to normalize the macros by removing redundancy. I'd like to figure
out the LDFLAGS use too though. It looks like the macro is assuming LDFLAGS to mean Go
compiler LDFLAGS. Which seems reasonable in the context of a Go spec file. So does that
mean that the macro can also assume that `BUILDTAGS` means Go compiler BUILDTAGS, because
it's in the context of a Go spec file? There /is/ already a way to define external
linker flags by setting `__golang_extldflags` to a value in the spec file (not sure I
agree with *that* name either, but there it is...), so I _believe_ it is safe to assume
that `LDFLAGS` means "pass these values to the Go compiler's `-ldflags` flag.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/35