alexsaezm opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Add -trimpath ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/31
alexsaezm commented on the pull-request: `Add -trimpath` that you are following: `` Any suggestions @eclipseo ? I'm not quite sure about including it in the `%{?gocompilerflags}` because it is used in `go test` and `-trimpath` is just for `go build` but I see duplicated flags so not really sure.
Also, do you think this could affect somehow the builds? Can't think of anything but better safe than sorry. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/31
eclipseo commented on the pull-request: `Add -trimpath` that you are following: `` This seems okay to me as is, but I don't know if it could affect the builds. A beta test in COPR might be useful. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/31
eclipseo commented on the pull-request: `Add -trimpath` that you are following: `` You should probably edit %gobuildflags() too? ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/31
eclipseo commented on the pull-request: `Add -trimpath` that you are following: `` I've tested some builds in a COPR: https://copr.fedorainfracloud.org/coprs/eclipseo/trimpath/builds/
They all fail, apparently no debuginfo are generated. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/31
alexsaezm commented on the pull-request: `Add -trimpath` that you are following: `` After considering it and talking with coworkers about why this flag was not included before, I think it doesn't make any sense, mainly because Koji builds in a sanitized build root, so nothing to leak. The same thing goes for reproducible builds.
I'll add a comment to the issue just in case there's something I'm missing. But otherwise, I think I should drop my PR :smile: ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/31
alexsaezm closed without merging a pull-request against the project: `go-rpm-macros` that you are following.
Closed pull-request:
`` Add -trimpath ``
golang@lists.fedoraproject.org
-
Alejandro Saez Morollon -
Robert-André Mauchin