[Bug 1060500] Review Request: golang-github-miekg-dns - Alternative (more granular) approach to a DNS library
https://bugzilla.redhat.com/show_bug.cgi?id=1060500
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dan.mashal@gmail.com
--- Comment #1 from Dan Mashal dan.mashal@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/dan/fedora- review/1060500-golang-github-miekg-dns/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL
===== MUST items =====
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /home/dan/fedora-review/1060500-golang-github-miekg- dns/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src(golang- github-gorilla-mux-devel, golang-googlecode-net-devel, golang-googlecode- goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang- googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang- github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang- github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode (golang-github-gorilla-mux-devel, golang-googlecode-net-devel, golang- googlecode-goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang-googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode/src/github.com(golang-github-gorilla-mux-devel, golang- github-syndtr-gocapability-devel, golang-github-coreos-go-systemd-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel) [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-miekg-dns-devel-0-0.1.gitdd3549666972.fc20.noarch.rpm golang-github-miekg-dns-0-0.1.gitdd3549666972.fc20.src.rpm golang-github-miekg-dns.src: W: file-size-mismatch miekg-dns-dd35496.tar.gz = 86959, https://github.com/miekg/dns/tarball/master/miekg-dns-dd35496.tar.gz = 89671 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint golang-github-miekg-dns-devel 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- golang-github-miekg-dns-devel (rpmlib, GLIBC filtered): golang
Provides -------- golang-github-miekg-dns-devel: golang(github.com/miekg/dns) golang-github-miekg-dns-devel
Source checksums ---------------- https://github.com/miekg/dns/tarball/master/miekg-dns-dd35496.tar.gz : CHECKSUM(SHA256) this package : 65b0514fe8ab288c3cb3bfa0bf6d59ef64dd3eb255945d78371d4e974eb8d50d CHECKSUM(SHA256) upstream package : 8d3e53d83d299f3090eab2bfd321c4c9c9deb2f992f02635ebceecf804d70325 diff -r also reports differences
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1060500 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
golang@lists.fedoraproject.org
-
Red Hat Bugzilla