[golist] Issue #28: golist fails when new go-1.17 `//go:build` style is used - golang - Fedora mailing-lists

29 Dec 2021


      mikelo2 reported a new issue against the project: `golist` that you are following:
``
golist fails when golang-1.17 new `//go:build` style is used:
```
$ go2rpm https://github.com/google/log4jscanner
//go:build comment without // +build comment
Traceback (most recent call last):
  File "/usr/bin/go2rpm", line 8, in <module>
    sys.exit(main())
  File "/usr/lib/python3.10/site-packages/go2rpm/__main__.py", line 598, in main
    buildrequires = to_list(get_buildrequires(forge, subdir))
  File "/usr/lib/python3.10/site-packages/go2rpm/__main__.py", line 442, in get_buildrequires
    buildrequires = subprocess.check_output(
  File "/usr/lib64/python3.10/subprocess.py", line 420, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib64/python3.10/subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['golist', '--imported', '--skip-self', '--package-path', 'github.com/google/log4jscanner']' returned non-zero exit status 1.
```
From go-1.17 release notes:
`
The go command now understands //go:build lines and prefers them over // +build lines. The new syntax uses boolean expressions, just like Go, and should be less error-prone. As of this release, the new syntax is fully supported, and all Go files should be updated to have both forms with the same meaning. To aid in migration, gofmt now automatically synchronizes the two forms. For more details on the syntax and migration plan, see https://golang.org/design/draft-gobuild. 
`
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/28