ngompa opened a new pull-request against the project: `go-rpm-macros` that you are following: `` rpm/macros.d: Make disabling Go modules configurable ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/22
ngompa commented on the pull-request: `rpm/macros.d: Make disabling Go modules configurable` that you are following: `` I know we have this flag set elsewhere in our macros, but I'm not sure how to make that a control everywhere. Moreover, I really only need it for `%gobuild` and `%gotest`... ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/22
nim commented on the pull-request: `rpm/macros.d: Make disabling Go modules configurable for %gobuild and %gotest` that you are following: `` @ngompa: please stay coherent with the exising macros and do not use `__` prefixing
Apart from that, why not, but enabling modules will break things right and left, so it’s a fire yourself in the foot setting
(go commands will start downloading right and left, go packahe naming resolution will fail because modules have special rules for versions in the import path, etc) ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/22
ngompa commented on the pull-request: `rpm/macros.d: Make disabling Go modules configurable for %gobuild and %gotest` that you are following: ``
(go commands will start downloading right and left, go packahe naming resolution will fail because modules have special rules for versions in the import path, etc)
I'm aware of this, but if I'm _only_ using `%gobuild` and `%gotest` in a package build that allows downloads and such (or has vendored modules), it should be fine. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/22
ngompa commented on the pull-request: `rpm/macros.d: Make disabling Go modules configurable for %gobuild and %gotest` that you are following: ``
@ngompa: please stay coherent with the exising macros and do not use __ prefixing
I dropped the prefix. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/22
ngompa merged a pull-request against the project: `go-rpm-macros` that you are following.
Merged pull-request:
`` rpm/macros.d: Make disabling Go modules configurable for %gobuild and %gotest ``
golang@lists.fedoraproject.org
-
Neal Gompa -
Nicolas Mailhot