Hi,
This is a heads-up regarding the impact of Go 1.24, now available in Fedora, and the subsequent mass-rebuild for Fedora 42. Over 200 packages are currently failing to build from source (FTBFS) [1] due to a stricter check introduced in Go 1.24 [2].
The failure occurs due to a stricter vet check requiring non-constant format strings to be explicitly handled. Affected builds fail with an error like:
non-constant format string in call to <function_name>
The failures typically occur during the %check phase, which is why "source-only" packages are also affected.
Fixing this issue is relatively simple, and some patches have already been submitted upstream [3][4]. However, addressing all affected packages downstream will likely take several months.
Best regards, Mikel
[1] https://koschei.fedoraproject.org/groups/go-sig?collection=f42 [2] https://tip.golang.org/doc/go1.24#vet [3] https://github.com/coreos/ignition/pull/2000 [4] https://github.com/opentofu/opentofu/pull/2390
Thank you for the heads up. I fixed the Hugo package, and I proposed a patch upstream:
https://github.com/gohugoio/hugo/pull/13285
FYI At least one of those FTBS packages is failing in C code because of a change to compile with -std=c23, not a golang issue.
Dave
On Mon, Jan 20, 2025 at 07:24:11AM +0100, Mikel Olasagasti via golang wrote:
Hi,
This is a heads-up regarding the impact of Go 1.24, now available in Fedora, and the subsequent mass-rebuild for Fedora 42. Over 200 packages are currently failing to build from source (FTBFS) [1] due to a stricter check introduced in Go 1.24 [2].
The failure occurs due to a stricter vet check requiring non-constant format strings to be explicitly handled. Affected builds fail with an error like:
non-constant format string in call to <function_name>The failures typically occur during the %check phase, which is why "source-only" packages are also affected.
Fixing this issue is relatively simple, and some patches have already been submitted upstream [3][4]. However, addressing all affected packages downstream will likely take several months.
Best regards, Mikel
[1] https://koschei.fedoraproject.org/groups/go-sig?collection=f42 [2] https://tip.golang.org/doc/go1.24#vet [3] https://github.com/coreos/ignition/pull/2000 [4] https://github.com/opentofu/opentofu/pull/2390 -- _______________________________________________ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Is there any way to disable this behavior when building with Fedora Go 1.24?
I have some upstream [1] that is not able to fix its code base any time soon which results in the package not being able to compile in Fedora 42 onwards.
Thanks for your advice, ganto
golang@lists.fedoraproject.org