Go 1.10 and PPC64LE builds

So like a lot of folks, I got an FTBFS when Go 1.10 landed in rawhide. After fixing things (some net/url changes bit this package's test suite), I have things building again, except on ppc64le:

```
+ go test -compiler gc -ldflags ' -extldflags '''-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '''' github.com/asaskevich/govalidator
/tmp/go-build843430853/b001/govalidator.test: error while loading shared libraries: R_PPC64_ADDR16_HA reloc at 0x000000013c40ba9c for symbol `' out of range
```
From: https://koji.fedoraproject.org/koji/taskinfo?taskID=24219288

All other arches build fine. This smells like a problem with the ppc64le builder (or the go compiler on that platform), but wanted to bounce it off the list before I spend too much time digging into it.

-Ed

[Jakub Cajka]

----- Original Message -----
> From: [e-mail]
> To: [e-mail]
> Sent: Monday, January 15, 2018 9:05:10 PM
> Subject: Go 1.10 and PPC64LE builds
>
> So like a lot of folks, I got an FTBFS when Go 1.10 landed in rawhide. After
> fixing things (some net/url changes bit this package's test suite), I have
> things building again, except on ppc64le:
> + go test -compiler gc -ldflags ' -extldflags '\''-Wl,-z,relro
> -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
> github.com/asaskevich/govalidator
> /tmp/go-build843430853/b001/govalidator.test: error while loading shared
> libraries: R_PPC64_ADDR16_HA reloc at 0x000000013c40ba9c for symbol `' out
> of range
>
> From: https://koji.fedoraproject.org/koji/taskinfo?taskID=24219288
>
> All other arches build fine. This smells like a problem with the ppc64le
> builder (or the go compiler on that platform), but wanted to bounce it off
> the list before I spend too much time digging into it.
>
> -Ed

Hm... that is old known issue, it should have been fixed in the 1.10. Will check.

Thanks for report,

JC
> golang mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Jakub Cajka]

----- Original Message -----
> From: "Jakub Cajka" 
> To: [e-mail]
> Sent: Tuesday, January 16, 2018 9:34:17 AM
> Subject: Re: Go 1.10 and PPC64LE builds
>
> ----- Original Message -----
> > From: [e-mail]
> > To: [e-mail]
> > Sent: Monday, January 15, 2018 9:05:10 PM
> > Subject: Go 1.10 and PPC64LE builds
> >
> > So like a lot of folks, I got an FTBFS when Go 1.10 landed in rawhide.
> > After
> > fixing things (some net/url changes bit this package's test suite), I have
> > things building again, except on ppc64le:
> > + go test -compiler gc -ldflags ' -extldflags '\''-Wl,-z,relro
> > -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
> > github.com/asaskevich/govalidator
> > /tmp/go-build843430853/b001/govalidator.test: error while loading shared
> > libraries: R_PPC64_ADDR16_HA reloc at 0x000000013c40ba9c for symbol `' out
> > of range
> >
> > From: https://koji.fedoraproject.org/koji/taskinfo?taskID=24219288
> >
> > All other arches build fine. This smells like a problem with the ppc64le
> > builder (or the go compiler on that platform), but wanted to bounce it off
> > the list before I spend too much time digging into it.
> >
> > -Ed
>
> Hm... that is old known issue, it should have been fixed in the 1.10. Will
> check.
>
> Thanks for report,
>
> JC

I think that I know where is the issue, problem is caused by the -pie flag to ld from hardening flags(that doesn't work on ppc64le for golang binaries). Adding buildmode pie should resolve this(https://kojipkgs.fedoraproject.org//work/tasks/8820/24228820/build.log). I will re-spin the go macros package to fix it distro wide, sorry for missing this out.

JC
> > golang mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> golang mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Jakub Cajka]

----- Original Message -----
> From: "Jakub Cajka" 
> To: [e-mail]
> Sent: Tuesday, January 16, 2018 1:52:44 PM
> Subject: Re: Go 1.10 and PPC64LE builds
>
> ----- Original Message -----
> > From: "Jakub Cajka" 
> > To: [e-mail]
> > Sent: Tuesday, January 16, 2018 9:34:17 AM
> > Subject: Re: Go 1.10 and PPC64LE builds
> >
> > ----- Original Message -----
> > > From: [e-mail]
> > > To: [e-mail]
> > > Sent: Monday, January 15, 2018 9:05:10 PM
> > > Subject: Go 1.10 and PPC64LE builds
> > >
> > > So like a lot of folks, I got an FTBFS when Go 1.10 landed in rawhide.
> > > After
> > > fixing things (some net/url changes bit this package's test suite), I
> > > have
> > > things building again, except on ppc64le:
> > > + go test -compiler gc -ldflags ' -extldflags '\''-Wl,-z,relro
> > > -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
> > > github.com/asaskevich/govalidator
> > > /tmp/go-build843430853/b001/govalidator.test: error while loading shared
> > > libraries: R_PPC64_ADDR16_HA reloc at 0x000000013c40ba9c for symbol `'
> > > out
> > > of range
> > >
> > > From: https://koji.fedoraproject.org/koji/taskinfo?taskID=24219288
> > >
> > > All other arches build fine. This smells like a problem with the ppc64le
> > > builder (or the go compiler on that platform), but wanted to bounce it
> > > off
> > > the list before I spend too much time digging into it.
> > >
> > > -Ed
> >
> > Hm... that is old known issue, it should have been fixed in the 1.10. Will
> > check.
> >
> > Thanks for report,
> >
> > JC
>
> I think that I know where is the issue, problem is caused by the -pie flag to
> ld from hardening flags(that doesn't work on ppc64le for golang binaries).
> Adding buildmode pie should resolve
> this(https://kojipkgs.fedoraproject.org//work/tasks/8820/24228820/build.log).
> I will re-spin the go macros package to fix it distro wide, sorry for
> missing this out.
>
> JC

This will go away when go-compilers-1-16.fc28 hits the repositories in day or so.

JC
> > > golang mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> >
> > golang mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> golang mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Ed Marshall]

On 1/16/18 5:03 AM, Jakub Cajka wrote:
> This will go away when go-compilers-1-16.fc28 hits the repositories in day or so.

Hi Jakub,

Looks like that did it, my ppc64le build finished successfully with go-compilers-1-16.fc28. :) Thanks for looking into this!