[go-rpm-macros] PR #37: srpm/go.lua: fix handling of version numbers with multiple digits
tomranta opened a new pull-request against the project: `go-rpm-macros` that you are following: `` srpm/go.lua: fix handling of version numbers with multiple digits ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/37
tomranta commented on the pull-request: `srpm/go.lua: fix handling of version numbers with multiple digits` that you are following: `` Fix handling of double digit version numbers, regression introduced in commit 65a2d82 ("srpm/go.lua: avoid remove char 'v' from project name").
Example: ``` $ grep goipath golang-github-playground-validator-10.spec %global goipath github.com/go-playground/validator/v10 ```
Before this patch: ``` $ rpmspec --srpm -q --qf '%{name}\n' golang-github-playground-validator-10.spec golang-github-playground-validator-v10 ```
After this patch: ``` $ rpmspec --srpm -q --qf '%{name}\n' golang-github-playground-validator-10.spec golang-github-playground-validator-10 ``` ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/37
jcajka commented on the pull-request: `srpm/go.lua: fix handling of version numbers with multiple digits` that you are following: `` I think this is wider issues that is caused by Go guidelines lagging behind the current state of Go, especially use of the modules and the release/version tags there. I guess the "v10" is actually correct if version/tag needs to be a part of the name of the packages. It will be compat package(there is need to carry more version of the same package in the distro) in a sense. IMHO general fix is to ignore [the versioning part of the import path](https://golang.org/ref/mod#versions) in the go rpm macros magic and let the version be defined by the rpm's version tag in spec. I'm aware that will most probably will be rather bigger undertaking, I guess including the update of the packaging guidelines. @alexsaezm @ngompa @dbenoit What are your takes here? ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/37
eclipseo merged a pull-request against the project: `go-rpm-macros` that you are following.
Merged pull-request:
`` srpm/go.lua: fix handling of version numbers with multiple digits ``
golang@lists.fedoraproject.org
-
Jakub Čajka -
Robert-André Mauchin
-
Tommi Rantala