[Bug 1227708] New: Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

Bug ID: 1227708
           Summary: Provide an additional sub-package with a skydns binary
           Product: Fedora
           Version: rawhide
         Component: golang-github-skynetservices-skydns
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]

Hello!
This packagew right now provides only a devel-package, totally ignoring its one
of the main purposes - skydns binary. Let's modify the package and introduce an
additional sub-package - with skydns executable.

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

Jan Chaloupka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Jan Chaloupka  ---
Hi Peter,

this was intentional as skydns depends on kubernetes and visa verse.

The latest tarball no longer depends on kubernetes.

skydns-6c94cbe92349cf550e64752a7cb72c98bcc44325]$ gofed ggi
--importpath=github.com/skynetservices/skydns
    github.com/coreos/go-etcd/etcd
    github.com/coreos/go-systemd/activation
    github.com/miekg/dns
    github.com/prometheus/client_golang/prometheus
    github.com/rcrowley/go-metrics
    github.com/rcrowley/go-metrics/stathat

But still there is no Godeps.json file or similar one listing commits of
imported packages.

I will take a look at that.

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

--- Comment #2 from Jan Chaloupka  ---
https://github.com/skynetservices/skydns/issues/184

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

Jan Chaloupka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #3 from Jan Chaloupka  ---
Peter,

can you checkout out the builds? I have added skydns.conf and skydns.service
files. SkyDNS is running over etcd so it has to be installed as well.

At the moment service file fails as I don't see more deeply into it. Can you
play with it and update service file (possibly skydns.conf file) to make it
work?

It there are other dependencies just let me know.

[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=9945220

Thanks
Jan

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

--- Comment #4 from Jan Chaloupka  ---
Anyway what release of skydns would you like to have? I have taken the latest
commit. The latest release is 2.5.0b.

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #5 from Peter Lemenkov  ---
(In reply to Jan Chaloupka from comment #3)
> Peter,
>
> can you checkout out the builds? I have added skydns.conf and skydns.service
> files. SkyDNS is running over etcd so it has to be installed as well.
>
> At the moment service file fails as I don't see more deeply into it. Can you
> play with it and update service file (possibly skydns.conf file) to make it
> work?

Jan, thanks for building this - I'll try it and post the results later.

(In reply to Jan Chaloupka from comment #4)
> Anyway what release of skydns would you like to have? I have taken the
> latest commit. The latest release is 2.5.0b.

Latest one is fine for me. Actually I don't have any preferences yet.(In reply
to Jan Chaloupka from comment #3)

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

--- Comment #6 from Jan Chaloupka  ---
Hi Peter, any positive/negative results?

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

--- Comment #7 from Peter Lemenkov  ---
(In reply to Jan Chaloupka from comment #6)
> Hi Peter, any positive/negative results?

Hello Jan!
The package works fine. However one has to setup at least ETCD_MACHINES
variable.

Also if something already opened port 53 (dnsmasq perhaps) then the default
configuration will fail. Note that 5353 will be likely occupied as well
(Avahi).

And the last issue is that you wrongly attributed %pre section - it should
belong to skydns package. So if someone installs only skydns then the skydns
user/group isn't exists.

systemd file I believe needs more improvements:

* Skydns can start using socket activation
* We should also specify a group (skydns), not only user. Although I don't use
it but I can imagine that someone adds some monitoring toos to skydns group to
retrieve some more details.
* How about dropping config file entirely? Let's use environment variables
stated in *service file explicitly. My personal biased opinion that it's better
because it makes package even simplier. A system administrator then adds
/etc/systemd/system/skydns.service.d/Something.conf if necessary (and only if
necessary).\

Apart from that it works fine!

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

--- Comment #8 from Jan Chaloupka  ---
> one has to setup at least ETCD_MACHINES variable.

Already set in skydns.conf. Is it not working?
> Also if something already opened port 53 (dnsmasq perhaps) then the default
> configuration will fail. Note that 5353 will be likely occupied as well (Avahi).

Would be great to have a list of all ports used by atomic and find one that is
reasonable and not conflicting with standard services. Any suggestions what
port it could be?
> systemd file I believe needs more improvements:
> Skydns can start using socket activation

How does it change the current service file?
> How about dropping config file entirely? Let's use environment variables stated
>
> in *service file explicitly.

I am not againts. What envs we should then set? At the moment we have only
ETCD_MACHINES="http://127.0.0.1:4001".

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

Fedora Admin XMLRPC Client  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]         |[e-mail]

--- Comment #10 from Fedora Admin XMLRPC Client  ---
This package has changed ownership in the Fedora Package Database.  Reassigning
to the new owner of this component.

[Bug 1227708] Provide an additional sub-package with a skydns binary

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227708

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2016-01-08 04:27:06

--- Comment #11 from Peter Lemenkov  ---
I think it's safe to close this - skydns is packaged and available in Fedora:

[root@lemenkov ~]# dnf list skydns
Last metadata expiration check performed 0:59:25 ago on Fri Jan  8 09:27:08
2016.
Available Packages
skydns.x86_64                                                                  
               2.5.3-0.1.a.git8688008.fc23                                     
                                            updates
[root@lemenkov ~]#