Re: F26 System Wide Change: Golang 1.8

[Jakub Cajka]

----- Original Message -----
>  From: jfilak(a)fedoraproject.org
>  To: jcajka(a)redhat.com
>  Cc: devel-announce(a)lists.fedoraproject.org, "Development discussions related to
> Fedora"
>  <devel(a)lists.fedoraproject.org&gt;
>  Sent: Tuesday, December 13, 2016 6:17:23 AM
>  Subject: Re: F26 System Wide Change: Golang 1.8
>  
>  
>  Jakub,
>  
>  
>  
>  
>  can we enable coredumping for Go programs by default - i.e. set GOTRACEBACK=
>  crash?
>  
>  
>  
>  
>  Currently, Go terminate  a process that panic and prints out an error
>  message on stderr.
>  
>  This approach does not provide much room for automatic Go panic detection.
>  
>   
It should be possible without any significant side effects apart from generating cores and
traces. But to enable this, I believe, it would need alteration to the default system env.
Would it be possible? What is the package providing the default env vars?

JC

> 
> 
> 
> 
> 
> 
> 
> 
> Regards,
> 
> Jakub
> 
> ABRT
> 
> 
> 
> 
> 
> ---------- Původní zpráva ----------
> Od: Jan Kurik <jkurik(a)redhat.com&gt;
> Komu: Development discussions related to Fedora <devel(a)lists.fedoraproject.
> org>, devel-announce(a)lists.fedoraproject.org
> Datum: 12. 12. 2016 12:32:15
> Předmět: F26 System Wide Change: Golang 1.8
> 
> "= Proposed System Wide Change: Golang 1.8 =
> https://fedoraproject.org/wiki/Changes/golang1.8
> 
> Change owner(s):
> * Jakub Čajka <jcajka AT redhat DOT com>
> 
> Rebase of Golang package to upcoming version 1.8 in Fedora 26,
> including rebuild of all dependent packages.
> 
> 
> == Detailed Description ==
> Rebase of Golang package to upcoming version 1.8 in Fedora 26. Golang
> 1.8 is schedule to be released in Feb. Due to current nature of Go
> packages, rebuild of dependent package will be required to pick up the
> changes.
> 
> 
> == Scope ==
> * Proposal owners:
> Rebase golang package in f26, help with resolving possible issues
> found during package rebuilds.
> 
> * Other developers:
> fix possible issues
> 
> * Release engineering:
> As there is scheduled mass-rebuild, nothing should be required.
> 
> * List of deliverables: N/A
> 
> * Policies and guidelines: N/A
> 
> * Trademark approval: N/A
> --
> Jan Kuřík
> Platform & Fedora Program Manager
> Red Hat Czech s.r.o., Purkynova 99/71, 612 45 Brno, Czech Republic
> _______________________________________________
> devel-announce mailing list -- devel-announce(a)lists.fedoraproject.org
> To unsubscribe send an email to devel-announce-leave(a)lists.fedoraproject.org
> "

F26 System Wide Change: Golang 1.8

[Zbigniew Jędrzejewski-Szmek]

On Tue, Dec 13, 2016 at 01:06:29PM -0500, Jakub Cajka wrote:
>  > can we enable coredumping for Go programs by default - i.e. set
> GOTRACEBACK=
>  > crash?
>  > 
>  > Currently, Go terminate  a process that panic and prints out an error
>  > message on stderr.
>  > 
>  > This approach does not provide much room for automatic Go panic detection.
>  
>  It should be possible without any significant side effects apart from generating cores
> and traces. But to enable this, I believe, it would need alteration to the default system
> env.  
Would it be possible? What is the package providing the default env vars?

systemd has DefaultEnvironment= in /etc/systemd/system.conf, but it is
supposed to be used to create local overrides, and doesn't work well
for this case (it's %config(noreplace) among other problems). In general
setting global env vars does not work.

Instead, it would be nicer to modify the go runtime to default to a coredump
if GOTRACEBACK= is not set. This would cover more cases and would not pollute
the environment for users who are not using go.

Zbyszek

F26 System Wide Change: Golang 1.8

[Jakub Filak]

Oh drat, I was hoping for a build time configuration option:

https://github.com/golang/go/issues/18304





Anyway, the env variable could be exported in the /etc/profile file which is
owned by the setup package. However, I don't think it is a good idea to 
place it there. I would rather export it in a file from the /etc/profile.d/ 
directory. The profile.d file should be delivered by a golang package that 
is required to run go programs.







Regards,

Jakub


---------- Původní zpráva ----------
Od: Jakub Cajka <jcajka(a)redhat.com&gt;
Komu: jfilak(a)fedoraproject.org
Datum: 13. 12. 2016 19:07:41
Předmět: Re: F26 System Wide Change: Golang 1.8

"



----- Original Message -----
>  From: jfilak(a)fedoraproject.org
>  To: jcajka(a)redhat.com
>  Cc: devel-announce(a)lists.fedoraproject.org, "Development discussions  
related
to Fedora"
>  <devel(a)lists.fedoraproject.org&gt;
>  Sent: Tuesday, December 13, 2016 6:17:23 AM
>  Subject: Re: F26 System Wide Change: Golang 1.8
>  
>  
>  Jakub,
>  
>  
>  
>  
>  can we enable coredumping for Go programs by default - i.e. set  
GOTRACEBACK=
>  crash?
>  
>  
>  
>  
>  Currently, Go terminate  a process that panic and prints out an error
>  message on stderr.
>  
>  This approach does not provide much room for automatic Go panic detection.
>  
>   
It should be possible without any significant side effects apart from 
generating cores and traces. But to enable this, I believe, it would need 
alteration to the default system env. Would it be possible? What is the 
package providing the default env vars?

JC

>  
>  
>  
>  
>  
>  
>  
>  
>  Regards,
>  
>  Jakub
>  
>  ABRT
>  
>  
>  
>  
>  
>  ---------- Původní zpráva ----------
>  Od: Jan Kurik <jkurik(a)redhat.com&gt;
>  Komu: Development discussions related to Fedora <devel@lists. 
fedoraproject.
>  org>, devel-announce(a)lists.fedoraproject.org
>  Datum: 12. 12. 2016 12:32:15
>  Předmět: F26 System Wide Change: Golang 1.8
>  
>  "= Proposed System Wide Change: Golang 1.8 =
>  https://fedoraproject.org/wiki/Changes/golang1.8
>  
>  Change owner(s):
>  * Jakub Čajka <jcajka AT redhat DOT com>
>  
>  Rebase of Golang package to upcoming version 1.8 in Fedora 26,
>  including rebuild of all dependent packages.
>  
>  
>  == Detailed Description ==
>  Rebase of Golang package to upcoming version 1.8 in Fedora 26. Golang
>  1.8 is schedule to be released in Feb. Due to current nature of Go
>  packages, rebuild of dependent package will be required to pick up the
>  changes.
>  
>  
>  == Scope ==
>  * Proposal owners:
>  Rebase golang package in f26, help with resolving possible issues
>  found during package rebuilds.
>  
>  * Other developers:
>  fix possible issues
>  
>  * Release engineering:
>  As there is scheduled mass-rebuild, nothing should be required.
>  
>  * List of deliverables: N/A
>  
>  * Policies and guidelines: N/A
>  
>  * Trademark approval: N/A
>  --
>  Jan Kuřík
>  Platform & Fedora Program Manager
>  Red Hat Czech s.r.o., Purkynova 99/71, 612 45 Brno, Czech Republic
>  _______________________________________________
>  devel-announce mailing list -- devel-announce(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-announce-leave(a)lists.fedoraproject. 
org
>  " 
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
"

F26 System Wide Change: Golang 1.8

[Jakub Filak]

I agree with Zbyzsek on this.




What about to carry a tiny down-stream patch until this issue is fixed:

https://github.com/golang/go/issues/18304
(https://github.com/golang/go/issues/18304)








Jakub


---------- Původní zpráva ----------
Od: Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt;
Komu: Development discussions related to Fedora <devel(a)lists.fedoraproject.
org>
Datum: 13. 12. 2016 19:35:01
Předmět: Re: F26 System Wide Change: Golang 1.8

"On Tue, Dec 13, 2016 at 01:06:29PM -0500, Jakub Cajka wrote:
>  > can we enable coredumping for Go programs by default - i.e. set 
GOTRACEBACK=
>  > crash?
>  > 
>  > Currently, Go terminate  a process that panic and prints out an error
>  > message on stderr.
>  > 
>  > This approach does not provide much room for automatic Go panic  
detection.
>  
>  It should be possible without any significant side effects apart from  
generating
cores and traces. But to enable this, I believe, it would need 
alteration to the default system env. 

Would it be possible? What is the package providing the default env vars?

systemd has DefaultEnvironment= in /etc/systemd/system.conf, but it is
supposed to be used to create local overrides, and doesn't work well
for this case (it's %config(noreplace) among other problems). In general
setting global env vars does not work.

Instead, it would be nicer to modify the go runtime to default to a coredump
if GOTRACEBACK= is not set. This would cover more cases and would not 
pollute
the environment for users who are not using go.

Zbyszek
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
"