[Bug 1087700] New: lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

Bug ID: 1087700
           Summary: lost signals when sending lots of signals using
                    --sig-proxy to docker
           Product: Fedora
           Version: 20
         Component: docker-io
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail], [e-mail],
                    [e-mail], [e-mail],
                    [e-mail]

Description of problem:
When I send lots of signals to the running docker with --sig-proxy (actual kill
signals, not `docker kill`), most of them got lost.

Version-Release number of selected component (if applicable):
docker-io-0.9.1-1.fc21.x86_64

How reproducible:
always

Steps to Reproduce:
1. /usr/bin/docker -D run --tty=false --rm -i --name test_eoly
localhost:5000/ldoktor/fedora:latest bash -c 'for NUM in `seq 1 64`; do trap
"echo Received $NUM, ignoring..." $NUM; done; while :; do sleep 1; done'
2. ps ax |grep docker
3. for AAA in `seq 1 32`; do [ $AAA -ne 9 ] && [ $AAA -ne 20 ] && [ $AAA -ne 19
] && kill -s $AAA $PID; done

Actual results:
Output of the docker is:
Received 1, ignoring...
Received 2, ignoring...

Expected results:
Messages for all of the `Received $NUM, ignoring...` printed (order doesn't
matter)

Additional info:
Skipping 9, 19, 20 as they are a bit too special..

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

--- Comment #1 from Lukas Doktor  ---
The same results with upstream docker dc9c28f/0.10.0:

Output:
Received 1, ignoring...
[debug] stdcopy.go:111 framesize: 24
Received 2, ignoring...

Daemon output:
2014/05/05 10:08:45 POST
/v1.10/containers/b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5/kill?signal=HUP
[/home/medic/Work/Projekty/Docker/root|fa3816b6] +job
kill(b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5, HUP)
[/home/medic/Work/Projekty/Docker/root|fa3816b6] -job
kill(b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5, HUP) =
OK (0)
2014/05/05 10:08:45 POST
/v1.10/containers/b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5/kill?signal=INT
[/home/medic/Work/Projekty/Docker/root|fa3816b6] +job
kill(b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5, INT)
[/home/medic/Work/Projekty/Docker/root|fa3816b6] -job
kill(b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5, INT) =
OK (0)

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

Lukas Doktor  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1096269

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1096269
[Bug 1096269] lost signals when sending lots of signals using --sig-proxy
to docker

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

Daniel Walsh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]             |[e-mail]

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

Daniel Walsh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |DUPLICATE
        Last Closed|                            |2014-06-03 16:33:28

--- Comment #2 from Daniel Walsh  ---

*** This bug has been marked as a duplicate of bug 1087697 ***

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

Lukas Doktor  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?([e-mail]
                   |                            |)

--- Comment #3 from Lukas Doktor  ---
Hi Daniel, I don't see the relation to bz1087697. This one is about docker not
handling signals properly (when sending them too quickly) and the bz1087697 is
about --sig-proxy not working in --tty=false mode.

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

Daniel Walsh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
         Resolution|DUPLICATE                   |---
           Keywords|                            |Reopened

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

--- Comment #4 from Daniel Walsh  ---
Ok sorry about that, I was doing a lot of cleanup yesterday and screwed up. 
This is the one we agreed would be a documentation issue correct.  IE Just
document which signals do not work?

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

--- Comment #5 from Lukas Doktor  ---
This one was about using `docker kill` very quickly/in parallel, which results
in missing signals in container, even when you use only the "safe" signals. So
documentation won't fix this issue (well you can add 1s wait in `docker kill`
;-) but I believe there is a better solution.

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

Daniel Walsh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]           |[e-mail]

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

--- Comment #6 from Matthew Heon  ---
A fix for this has made its way upstream
(https://github.com/dotcloud/docker/pull/6508#issuecomment-48211901), and
should be included in the next upstream release of Docker.

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

Daniel Walsh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #7 from Daniel Walsh  ---
Fixed in docker-1.2

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

--- Comment #8 from Lukas Doktor  ---
Thank you, this seems to be working fine on docker-1.2.0-19.el7.x86_64 (apart
from the usually broken signals...)

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

John Skeoch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]            |[e-mail]

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

--- Comment #10 from Fedora End Of Life  ---
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

[Bug 1087700] lost signals when sending lots of signals using --sig-proxy to docker

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1087700

Daniel Walsh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20                          |22