krouma opened a new pull-request against the project: `golist` that you are following: `` Don't skip testdata ``
To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/30
eclipseo commented on the pull-request: `Don't skip testdata` that you are following: `` Hmmm, in general I add them manually but ok. ``
To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/30
eclipseo merged a pull-request against the project: `golist` that you are following.
Merged pull-request:
`` Don't skip testdata ``
qulogic commented on the pull-request: `Don't skip testdata` that you are following: `` Sorry, I've had to revert this change. After applying it, it causes several bugs:
1. `testdata` that includes invalid Go code can cause `golist` to panic, as it does so when importing a directory fails. 2. Imports in `testdata` now get added as dependencies, which can break `%go_generate_buildrequires`, if these are non-existent. 3. `%gocheck` attempts to run tests on `testdata` code, but that's not how Go does it. These files may be invalid as well, causing `%check` to fail. ``
To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/30
golang@lists.fedoraproject.org
-
Elliott Sales de Andrade -
Matyáš Kroupa
-
Robert-André Mauchin