[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist

[Elliott Sales de Andrade]

qulogic reported a new issue against the project: `go-rpm-macros` that you are following:
``
In the old version of
[golang-github-pkg-errors](https://src.fedoraproject.org/rpms/golang-githu...,
there was a typo, and `glide.yaml` was listed twice in the sources. This meant that
`glide.lock` was never copied to the source directory.

When `%goinstall glide.yaml glide.lock` was called later, it created a `glide.lock`
_directory_. Now that I'm trying to fix it, it causes [an upgrade
error](https://bodhi.fedoraproject.org/updates/FEDORA-2019-f01a015bb7#com...
since rpm can't handle a directory->file change. So now I need to go throw in a
scriptlet to fix the directory.

`%goinstall` should not accept an explicit path argument that does not exist, and should
fail the build. If it really needs to be able to create arbitrary directories like that,
it should be behind an explicit flag (like `install -d` is).
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/7

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
Yes goinstall error checking should be improved (even though the target will be modules
soonish that should hopefully remove the need for custom install hacks)
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/7

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
(BTW did you check what happens with the current macro version? This part has been
refactored for more robustness, even though this is definitely a case I didn't check
so if it's fixed it's fixed as a side effect of something else ;))
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/7

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
Ok I've checked the current code and the problem also exists here.

I have a fix, will commit it once I'm somewhere that allows ssh access to pagure
(since pagure does not allow https commits)
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/7

[Nicolas Mailhot]

The status of the issue: `%goinstall should verify explicit paths exist` of project:
`go-rpm-macros` has been updated to: Closed by nim.

https://pagure.io/go-rpm-macros/issue/7

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
And the fix is now in rawhide, with go-rpm-macros 3.0.8
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/7