[PATCH] Fix cast issue
by Simo Sorce
While looking at a bug I found this issue where we try to cast a
pointer to an unsigned int to size_t.
That doesn't work except by luck on a little endian machine, and even
there if unsigned int != size_t (32 bit machines) overwrite other data
so we've been also double lucky that whatever was overwritten didn't
matter.
I may find other issues but this was self-contained enough to merit its
own patch sent out asap.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
9 years, 1 month
[PATCHES] Better logging for basic errors and tests fixes
by Simo Sorce
One of the most frequent issues with gss-proxy is that of acquiring
credentials when interposing client processes.
The attached patchset adds proper logging (to syslog or journal) when
GSS-Proxy fails to acquire credentials. Hopefully it won't be too
spammy.
Also find attached a set of patches to fix the test framework which
was not actually testing the GSS-Proxy daemon (oops :-)
Simo.
--
Simo Sorce * Red Hat, Inc * New York
9 years, 1 month
[PATCH] Fix possible crashes in gssapi
by Simo Sorce
The mechglue expects the outputs to be zeroed by the mechanism even
though it allocates the gss_buffer_t structure.
Failing to do may lead to a segfault in free() if the display_name
function returns an error.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
9 years, 3 months
[PATCH] BUILD: Fix building with automake 1.15
by Lukas Slebodnik
ehlo,
I was testing mock build of srpm just on fedora-21.
But there is a problem on rawhide due to newer version of automake.
and Stephan's static analysers cron job uses rawhide for testing.
I tested mock build on fedora-{20,21,rawhide} epel7 with attached patch.
LS
9 years, 3 months
[PATCH] Use defined enum instead of constant
by Lukas Slebodnik
ehlo,
This is just a suppress warnig because 0 was not cosideread as appropriate enum
type. From functional point of view there is no difference.
Value of enum gp_rpc_accept_status GP_RPC_SUCCESS is 0
Value of enum gp_rpc_reject_status GP_RPC_RPC_MISMATCH is 0
LS
9 years, 3 months
[PATCH] Wrong coversion function was used
by Lukas Slebodnik
ehlo,
this was found by static analysers which noticed taht wrong enum type was
used as an argument and as a return value.
It works due to the same values of then enum types.
LS
9 years, 3 months
[PATCH] Suppress clang warning
by Lukas Slebodnik
ehlo,
Result of 'malloc' is converted to a pointer of type 'uint32_t', which is
incompatible with sizeof operand type 'int32_t'
LS
9 years, 3 months
