>From 18c087bd76822e8350ec61f070121c77fa9725c9 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 28 Mar 2015 12:49:54 +0100 Subject: [PATCH 1/5] Fix warning value stored to 'ret' is never read Error: UNUSED_VALUE src/gp_rpc_import_and_canon_name.c:87: value_overwrite: Overwriting previous write to "ret" with value from "gp_conv_status_to_gssx(&icna->call_ctx, ret_maj, ret_min, mech, &icnr->status)". src/gp_rpc_import_and_canon_name.c:52: assigned_value: Assigning value "22" to "ret" here, but that stored value is overwritten before it can be used. --- proxy/src/gp_rpc_import_and_canon_name.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proxy/src/gp_rpc_import_and_canon_name.c b/proxy/src/gp_rpc_import_and_canon_name.c index 1988a8bd99fb2129fc5fd54f5e32f777da121c70..5434e22e18856c364c0bae7642acd5f5df95d8a2 100644 --- a/proxy/src/gp_rpc_import_and_canon_name.c +++ b/proxy/src/gp_rpc_import_and_canon_name.c @@ -49,7 +49,8 @@ int gp_import_and_canon_name(struct gp_call_ctx *gpcall, if (icna->input_name.display_name.octet_string_len == 0 && icna->input_name.exported_name.octet_string_len == 0) { - ret = EINVAL; + ret_maj = GSS_S_FAILURE; + ret_min = EINVAL; goto done; } -- 2.3.4