The mechglue expects the outputs to be zeroed by the mechanism even though it allocates the gss_buffer_t structure. Failing to do may lead to a segfault in free() if the display_name function returns an error.
Simo.
----- Original Message -----
From: "Simo Sorce" simo@redhat.com To: gss-proxy@lists.fedorahosted.org Sent: Thursday, January 22, 2015 8:47:38 PM Subject: [gssproxy] [PATCH] Fix possible crashes in gssapi
The mechglue expects the outputs to be zeroed by the mechanism even though it allocates the gss_buffer_t structure. Failing to do may lead to a segfault in free() if the display_name function returns an error.
I didn't build or test it yet but IMHO it makes sense... so r=rmainz@redhat.com ...
----
Bye, Roland
On Thu, 22 Jan 2015 14:50:38 -0500 (EST) Roland Mainz rmainz@redhat.com wrote:
----- Original Message -----
From: "Simo Sorce" simo@redhat.com To: gss-proxy@lists.fedorahosted.org Sent: Thursday, January 22, 2015 8:47:38 PM Subject: [gssproxy] [PATCH] Fix possible crashes in gssapi
The mechglue expects the outputs to be zeroed by the mechanism even though it allocates the gss_buffer_t structure. Failing to do may lead to a segfault in free() if the display_name function returns an error.
I didn't build or test it yet but IMHO it makes sense... so r=rmainz@redhat.com ...
Thank you, I fixed a typo and clarified the commit message and pushed with your reviewed-by
Simo.
gss-proxy@lists.fedorahosted.org