This is an automated email from the git hooks/post-receive script.
simo pushed a change to branch master in repository gssproxy.
from 34501e6 Release version 0.5.0 new 518e1c1 Fix return check on gp_conv_gssx_to_name
The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference.
Summary of changes: proxy/src/gp_creds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
This is an automated email from the git hooks/post-receive script.
simo pushed a commit to branch master in repository gssproxy.
commit 518e1c10bcfc96fd3164b3eec77baadcc32594b6 Author: Robbie Harwood rharwood@redhat.com Date: Mon May 16 14:50:13 2016 -0400
Fix return check on gp_conv_gssx_to_name
This bug was found by Coverity.
Merges #25
Signed-off-by: Robbie Harwood rharwood@redhat.com Reviewed-by: Simo Sorce simo@redhat.com --- proxy/src/gp_creds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/proxy/src/gp_creds.c b/proxy/src/gp_creds.c index 551b020..446c7d8 100644 --- a/proxy/src/gp_creds.c +++ b/proxy/src/gp_creds.c @@ -580,7 +580,9 @@ uint32_t gp_add_krb5_creds(uint32_t *min, } else if (desired_name) { ret_maj = gp_conv_gssx_to_name(&ret_min, desired_name, &req_name); } - if (ret_min) { + if (ret_maj) { + goto done; + } else if (ret_min) { ret_maj = GSS_S_CRED_UNAVAIL; goto done; }
gss-proxy@lists.fedorahosted.org