[PATCH] Fix cast issue

[Simo Sorce]

While looking at a bug I found this issue where we try to cast a
pointer to an unsigned int to size_t.
That doesn't work except by luck on a little endian machine, and even
there if unsigned int != size_t (32 bit machines) overwrite other data
so we've been also double lucky that whatever was overwritten didn't
matter.

I may find other issues but this was self-contained enough to merit its
own patch sent out asap.

Simo.
-- 
Simo Sorce * Red Hat, Inc * New York

[Simo Sorce]

On Mon, 15 Dec 2014 13:56:55 -0500
Simo Sorce <simo(a)redhat.com&gt; wrote:

>  
>  While looking at a bug I found this issue where we try to cast a
>  pointer to an unsigned int to size_t.
>  That doesn't work except by luck on a little endian machine, and even
>  there if unsigned int != size_t (32 bit machines) overwrite other data
>  so we've been also double lucky that whatever was overwritten didn't
>  matter.
>  
>  I may find other issues but this was self-contained enough to merit
>  its own patch sent out asap.
>  
>  Simo. 
Ups this patch had a typo ...

Updated patch attached.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Simo Sorce]

On Tue, 2014-12-16 at 12:43 -0500, Simo Sorce wrote:
>  On Mon, 15 Dec 2014 13:56:55 -0500
>  Simo Sorce <simo(a)redhat.com&gt; wrote:
>  
>  > 
>  > While looking at a bug I found this issue where we try to cast a
>  > pointer to an unsigned int to size_t.
>  > That doesn't work except by luck on a little endian machine, and even
>  > there if unsigned int != size_t (32 bit machines) overwrite other data
>  > so we've been also double lucky that whatever was overwritten didn't
>  > matter.
>  > 
>  > I may find other issues but this was self-contained enough to merit
>  > its own patch sent out asap.
>  > 
>  > Simo.
>  
>  Ups this patch had a typo ...
>  
>  Updated patch attached. 
New patch with typos fixed  (again :-)

Bump up for review.
Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Nathaniel McCallum]

ACK

On Sat, 2015-03-21 at 14:37 -0400, Simo Sorce wrote:
>  On Tue, 2014-12-16 at 12:43 -0500, Simo Sorce wrote:
>  > On Mon, 15 Dec 2014 13:56:55 -0500
>  > Simo Sorce <simo(a)redhat.com&gt; wrote:
>  > 
>  > > 
>  > > While looking at a bug I found this issue where we try to cast a
>  > > pointer to an unsigned int to size_t.
>  > > That doesn't work except by luck on a little endian machine, and 
>  > > even
>  > > there if unsigned int != size_t (32 bit machines) overwrite 
>  > > other data
>  > > so we've been also double lucky that whatever was overwritten 
>  > > didn't
>  > > matter.
>  > > 
>  > > I may find other issues but this was self-contained enough to 
>  > > merit
>  > > its own patch sent out asap.
>  > > 
>  > > Simo.
>  > 
>  > Ups this patch had a typo ...
>  > 
>  > Updated patch attached.
>  
>  New patch with typos fixed  (again :-)
>  
>  Bump up for review.
>  Simo.
>  
>  _______________________________________________
>  gss-proxy mailing list
>  gss-proxy(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/gss-proxy

[Roland Mainz]

----- Original Message -----
>  From: "Simo Sorce" <simo(a)redhat.com&gt;
>  To: gss-proxy(a)lists.fedorahosted.org
>  Cc: "Roland Mainz" <rmainz(a)redhat.com&gt;
>  Sent: Saturday, March 21, 2015 7:37:41 PM
>  Subject: Re: [gssproxy] [PATCH] Fix cast issue
>  
>  On Tue, 2014-12-16 at 12:43 -0500, Simo Sorce wrote:
>  > On Mon, 15 Dec 2014 13:56:55 -0500
>  > Simo Sorce <simo(a)redhat.com&gt; wrote:
>  > 
>  > > 
>  > > While looking at a bug I found this issue where we try to cast a
>  > > pointer to an unsigned int to size_t.
>  > > That doesn't work except by luck on a little endian machine, and even
>  > > there if unsigned int != size_t (32 bit machines) overwrite other data
>  > > so we've been also double lucky that whatever was overwritten didn't
>  > > matter.
>  > > 
>  > > I may find other issues but this was self-contained enough to merit
>  > > its own patch sent out asap.
>  > > 
>  > > Simo.
>  > 
>  > Ups this patch had a typo ...
>  > 
>  > Updated patch attached.
>  
>  New patch with typos fixed  (again :-) 
r=rmainz(a)redhat.com for the patch...

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) rmainz(a)redhat.com
  \__\/\/__/  IPA/Kerberos5 team
  /O /==\ O\  
 (;O/ \/ \O;)