Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488665
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |NEXTRELEASE
--- Comment #6 from Jens Petersen <petersen(a)redhat.com> 2009-03-18 01:42:50 EDT ---
imported and built
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488665
Kevin Fenzi <kevin(a)tummy.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi <kevin(a)tummy.com> 2009-03-17 23:31:06 EDT ---
cvs done.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=426753
--- Comment #25 from Jens Petersen <petersen(a)redhat.com> 2009-03-17 04:47:16 EDT ---
Thanks for the update.
> Note that fileperms was fixed too. This is an issue that seems to be common to
> haskell things compiled in ghc, so we may want to fix this in the template.
You need to do that just for the bin file like I did with hscolour, not for all
files, like this:
%files
%defattr(-,root,root,-)
%doc LICENSE
%attr(755,root,root) %{_bindir}/%{name}
Otherwise looks ok to me: I would like test it in rawhide and then do the final
review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488665
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
--- Comment #4 from Jens Petersen <petersen(a)redhat.com> 2009-03-17 04:34:16 EDT ---
Thanks for the review.
New Package CVS Request
=======================
Package Name: hscolour
Short Description: Haskell source highlighting
Owners: petersen
Branches: F-10
InitialCC: haskell-sig
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=426753
--- Comment #24 from Yaakov Nemoy <loupgaroublond(a)gmail.com> 2009-03-13 19:40:18 EDT ---
New update
SPEC: http://ynemoy.fedorapeople.org/review/xmonad.spec
SRPM: http://ynemoy.fedorapeople.org/review/xmonad-0.8.1-4.fc10.src.rpm
Arguably, this package needs to be rebuilt everytime there's an update to X11,
because of static compilation. Still, there is one use case for giving a more
generic required version of ghc-X11, and that is the user who needs to
recompile to an earlier version for what ever reason.
Note that fileperms was fixed too. This is an issue that seems to be common to
haskell things compiled in ghc, so we may want to fix this in the template.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488665
Yaakov Nemoy <loupgaroublond(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Yaakov Nemoy <loupgaroublond(a)gmail.com> 2009-03-13 19:00:09 EDT ---
Ok, URL is good.
Waiving the warnings and error that can be waived for the obvious reasons. They
were included only for completeness.
I'm gonna let the executable-stack warning pass for now. This might bear some
looking into.
The other issues have been fixed, so this is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=426753
--- Comment #23 from Yaakov Nemoy <loupgaroublond(a)gmail.com> 2009-03-13 18:59:54 EDT ---
$ python
>>> import this
<snip>
Explicit is better than implicit.
<snip>
Anyways, we need to include ghc-xmonad-devel because xmonad can and will
recompile itself on the fly.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479799
--- Comment #3 from Conrad Meyer <konrad(a)tylerc.org> 2009-03-13 02:15:30 EDT ---
Me, I think -- I think I need to update to the new Haskell templates.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479799
--- Comment #2 from Jason Tibbitts <tibbs(a)math.uh.edu> 2009-03-13 02:10:00 EDT ---
Who is Jens pinging?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.