Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609528
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
--- Comment #3 from Jens Petersen <petersen(a)redhat.com> 2010-09-01 01:47:11 EDT ---
Thanks, Ben :)
New Package SCM Request
=======================
Package Name: ghc-cairo
Short Description: Haskell Cairo bindings
Owners: petersen
Branches: f14
InitialCC: haskell-sig
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609528
Ben Boeckel <mathstuf(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |mathstuf(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |mathstuf(a)gmail.com
Flag| |fedora-review+
--- Comment #2 from Ben Boeckel <mathstuf(a)gmail.com> 2010-09-01 01:02:10 EDT ---
Taken.
+:ok, !:needs attention, -:needs fixing, NA: not applicable
MUST Items:
[!] MUST: rpmlint output
% lintmock fedora-14-x86_64-bb
ghc-cairo.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell,
Skellum
ghc-cairo.src: W: spelling-error %description -l en_US Haskell -> Gaskell,
Gaitskell, Skellum
ghc-cairo.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-cairo.x86_64: W: spelling-error %description -l en_US Haskell -> Gaskell,
Gaitskell, Skellum
ghc-cairo-devel.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-cairo-devel.x86_64: W: spelling-error %description -l en_US Haskell ->
Gaskell, Gaitskell, Skellum
ghc-cairo-prof.x86_64: E: devel-dependency ghc-cairo-devel
ghc-cairo-prof.x86_64: W: spelling-error %description -l en_US Haskell ->
Gaskell, Gaitskell, Skellum
ghc-cairo-prof.x86_64: W: no-documentation
ghc-cairo-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/cairo-0.11.1/libHScairo-0.11.1_p.a
4 packages and 0 specfiles checked; 1 errors, 9 warnings.
All standard and waived
[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license.
[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release
01056ece6c8872d30cbc0f11eef98e40 cairo-0.11.1.tar.gz
[+] MUST: must successfully compile and build into binary rpms on one main arch
Requires ghc-glib which isn't in Fedora yet. Builds locally.
[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages which store shared library files in the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Every %files section must
include a %defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items:
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
Yay cabal2spec. Looks good.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=629145
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora-haskell-list@redhat.
| |com
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620046
Ben Boeckel <mathstuf(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |mathstuf(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |mathstuf(a)gmail.com
Flag| |fedora-review?
--- Comment #2 from Ben Boeckel <mathstuf(a)gmail.com> 2010-09-01 00:42:32 EDT ---
I can take this. rpmlint output:
% lintmock fedora-14-x86_64-bb
ghc-terminfo.src: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-terminfo.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-terminfo-devel.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-terminfo-prof.x86_64: E: devel-dependency ghc-terminfo-devel
ghc-terminfo-prof.x86_64: W: no-documentation
ghc-terminfo-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/terminfo-0.3.1.3/libHSterminfo-0.3.1.3_p.a
4 packages and 0 specfiles checked; 1 errors, 5 warnings.
Have to test the sed script then (will use yi from cabal against it).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609518
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
--- Comment #6 from Jens Petersen <petersen(a)redhat.com> 2010-08-31 23:58:23 EDT ---
Thanks for reviewing. :)
New Package SCM Request
=======================
Package Name: ghc-glib
Short Description: Haskell binding for glib2
Owners: petersen
Branches: f14
InitialCC: haskell-sig
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=460974
Jens Petersen <petersen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody(a)fedoraproject.org |petersen(a)redhat.com
Status Whiteboard|notready |
Flag| |fedora-review?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609518
Ben Boeckel <mathstuf(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review+
--- Comment #5 from Ben Boeckel <mathstuf(a)gmail.com> 2010-08-31 23:35:57 EDT ---
And the flag...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=629124
--- Comment #2 from Ben Boeckel <mathstuf(a)gmail.com> 2010-08-31 23:17:53 EDT ---
strange-permission warnings are a result of my 027 umask. Koji's results should
be free of those (git does 644 and 755 perms only).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.