https://bugzilla.redhat.com/show_bug.cgi?id=1037066
Bug ID: 1037066
Summary: fontmatrix FTBFS if "-Werror=format-security" flag is
used
Product: Fedora
Version: rawhide
Component: fontmatrix
Assignee: pnemade(a)redhat.com
Reporter: dkholia(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: fonts-bugs(a)lists.fedoraproject.org,
i18n-bugs(a)lists.fedoraproject.org, pnemade(a)redhat.com
Description of problem
----------------------
fontmatrix fails to build if "-Werror=format-security" flag is used.
...
/builddir/build/BUILD/fontmatrix-0.9.99-Source/src/fmsharestruct.h:93:45:
error: format not a string literal and no format arguments
[-Werror=format-security]
...
We are working on a proposal to enable "-Werror=format-security" for all
packages. Once this flag is enabled, GCC will refuse to compile code that could
be vulnerable to a string format security flaw. For more details, please see
https://fedorahosted.org/fesco/ticket/1185 page.
To understand why it is important to fix this, please see
https://fedoraproject.org/wiki/Format-Security-FAQ page.
How to fix this
---------------
The fix for these errors is quite simple. It's a matter of changing a
line like,
printf(foo);
to read,
printf("%s", foo);
That's it.
Please fix this issue in rawhide with a patch (which you should submit
to upstream to merge moving forward). Please do a new build with the
fix in rawhide. Other releases do not need to be directly fixed, but
there should be no harm in pushing out this fix/patch with other needed
changes to those branches.
In the event you don't fix this bug before the next mass rebuild,
provenpackagers may step in and update your package(s) to fix this
issue.
How reproducible
----------------
Build fontmatrix-0.9.99-13.r1218.fc20.src.rpm with "-Werror=format-security"
flag to reproduce the problem.
To make this process easier, you can use a modified "redhat-rpm-config" package
from http://people.fedoraproject.org/~halfie/artifacts/redhat-rpm-config/ URL.
$ sha256sum redhat-rpm-config-9.1.0-56.fc20.*
faad7594b2080fe76497d0ce50808c905a93dd7b41c1defdde5ca57e3833d3d2
redhat-rpm-config-9.1.0-56.fc20.noarch.rpm
5aa9357174305c7285ffdbc92d7ffe1c07a8a95d5459b930461308f5aad75413
redhat-rpm-config-9.1.0-56.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TjzM5u5Hbu&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1036351
Nils Philippsen <nphilipp(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fonts-bugs(a)lists.fedoraproj
| |ect.org,
| |i18n-bugs(a)lists.fedoraproje
| |ct.org, tagoh(a)redhat.com
Component|gimp |pango
Assignee|nphilipp(a)redhat.com |tagoh(a)redhat.com
--- Comment #11 from Nils Philippsen <nphilipp(a)redhat.com> ---
Looks like a division by zero here:
--- 8< --- pango/pango-layout.c:6098 -- pango_layout_iter_get_char_extents()
---
x0 = (iter->character_position * cluster_rect.width) / iter->cluster_num_chars;
--- >8 ---
The cluster_num_chars member is opaque to outside API users, so IMO has to be
set by pango itself:
--- 8< --- app/tools/gimptexttool.c:841 -- gimp_text_tool_draw_selection() ---
iter = pango_layout_get_iter (layout);
gimp_draw_tool_push_group (draw_tool, fill_group);
do
{
if (! pango_layout_iter_get_run (iter))
continue;
i = pango_layout_iter_get_index (iter);
if (i >= min && i < max)
{
PangoRectangle rect;
gint ytop, ybottom;
pango_layout_iter_get_char_extents (iter, &rect);
pango_layout_iter_get_line_yrange (iter, &ytop, &ybottom);
rect.y = ytop;
rect.height = ybottom - ytop;
pango_extents_to_pixels (&rect, NULL);
gimp_text_layout_transform_rect (text_tool->layout, &rect);
rect.x += offset_x;
rect.y += offset_y;
gimp_draw_tool_add_rectangle (draw_tool, TRUE,
rect.x, rect.y,
rect.width, rect.height);
}
}
while (pango_layout_iter_next_char (iter));
--- >8 ---
Changing component to pango.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IWi2ipoK1g&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1037380
Bug ID: 1037380
Summary: w3m FTBFS if "-Werror=format-security" flag is used
Product: Fedora
Version: rawhide
Component: w3m
Assignee: pnemade(a)redhat.com
Reporter: dkholia(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: i18n-bugs(a)lists.fedoraproject.org, pnemade(a)redhat.com
Description of problem
----------------------
w3m fails to build if "-Werror=format-security" flag is used.
...
w3mbookmark.c:102:2: error: format not a string literal and no format arguments
[-Werror=format-security]
...
We are working on a proposal to enable "-Werror=format-security" for all
packages. Once this flag is enabled, GCC will refuse to compile code that could
be vulnerable to a string format security flaw. For more details, please see
https://fedorahosted.org/fesco/ticket/1185 page.
To understand why it is important to fix this, please see
https://fedoraproject.org/wiki/Format-Security-FAQ page.
How to fix this
---------------
The fix for these errors is quite simple. It's a matter of changing a
line like,
printf(foo);
to read,
printf("%s", foo);
That's it.
Please fix this issue in rawhide with a patch (which you should submit
to upstream to merge moving forward). Please do a new build with the
fix in rawhide. Other releases do not need to be directly fixed, but
there should be no harm in pushing out this fix/patch with other needed
changes to those branches.
In the event you don't fix this bug before the next mass rebuild,
provenpackagers may step in and update your package(s) to fix this
issue.
How reproducible
----------------
Build w3m-0.5.3-13.fc20.src.rpm with "-Werror=format-security" flag to
reproduce the problem.
To make this process easier, you can use a modified "redhat-rpm-config" package
from http://people.fedoraproject.org/~halfie/artifacts/redhat-rpm-config/ URL.
$ sha256sum redhat-rpm-config-9.1.0-56.fc20.*
faad7594b2080fe76497d0ce50808c905a93dd7b41c1defdde5ca57e3833d3d2
redhat-rpm-config-9.1.0-56.fc20.noarch.rpm
5aa9357174305c7285ffdbc92d7ffe1c07a8a95d5459b930461308f5aad75413
redhat-rpm-config-9.1.0-56.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IC18xxnd7u&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1037338
Bug ID: 1037338
Summary: stardict FTBFS if "-Werror=format-security" flag is
used
Product: Fedora
Version: rawhide
Component: stardict
Assignee: apatil(a)redhat.com
Reporter: dkholia(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: apatil(a)redhat.com, i18n-bugs(a)lists.fedoraproject.org,
nav007(a)gmail.com, pwu(a)redhat.com,
robinlee.sysu(a)gmail.com, supercyper1(a)gmail.com,
zhu(a)redhat.com
Description of problem
----------------------
stardict fails to build if "-Werror=format-security" flag is used.
...
desktop.cpp:265:7: error: format not a string literal and no format arguments
[-Werror=format-security]
...
We are working on a proposal to enable "-Werror=format-security" for all
packages. Once this flag is enabled, GCC will refuse to compile code that could
be vulnerable to a string format security flaw. For more details, please see
https://fedorahosted.org/fesco/ticket/1185 page.
To understand why it is important to fix this, please see
https://fedoraproject.org/wiki/Format-Security-FAQ page.
How to fix this
---------------
The fix for these errors is quite simple. It's a matter of changing a
line like,
printf(foo);
to read,
printf("%s", foo);
That's it.
Please fix this issue in rawhide with a patch (which you should submit
to upstream to merge moving forward). Please do a new build with the
fix in rawhide. Other releases do not need to be directly fixed, but
there should be no harm in pushing out this fix/patch with other needed
changes to those branches.
In the event you don't fix this bug before the next mass rebuild,
provenpackagers may step in and update your package(s) to fix this
issue.
How reproducible
----------------
Build stardict-3.0.4-7.fc20.src.rpm with "-Werror=format-security" flag to
reproduce the problem.
To make this process easier, you can use a modified "redhat-rpm-config" package
from http://people.fedoraproject.org/~halfie/artifacts/redhat-rpm-config/ URL.
$ sha256sum redhat-rpm-config-9.1.0-56.fc20.*
faad7594b2080fe76497d0ce50808c905a93dd7b41c1defdde5ca57e3833d3d2
redhat-rpm-config-9.1.0-56.fc20.noarch.rpm
5aa9357174305c7285ffdbc92d7ffe1c07a8a95d5459b930461308f5aad75413
redhat-rpm-config-9.1.0-56.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gDKCs666wq&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1038009
Bug ID: 1038009
Summary: FTBFS due to compilation error
Product: Fedora
Version: rawhide
Component: w3m
Assignee: pnemade(a)redhat.com
Reporter: pnemade(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: i18n-bugs(a)lists.fedoraproject.org, pnemade(a)redhat.com
Description of problem:
when tried to fix bug 1037380 ,got following compilation error
------------------------------------------------------------------------------
gcc -I. -I. -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches -m64 -mtune=generic -I./libwc -DHAVE_CONFIG_H
-DAUXBIN_DIR=\"/usr/libexec/w3m\" -DCGIBIN_DIR=\"/usr/libexec/w3m/cgi-bin\"
-DHELP_DIR=\"/usr/share/w3m\" -DETC_DIR=\"/etc\" -DCONF_DIR=\"/etc/w3m\"
-DRC_DIR=\"~/.w3m\" -DLOCALEDIR=\"/usr/share/locale\" -c -o frame.o frame.c
etc.c:638:8: error: conflicting types for 'sys_errlist'
char **sys_errlist;
^
In file included from /usr/include/stdio.h:853:0,
from fm.h:18,
from etc.c:2:
/usr/include/bits/sys_errlist.h:27:26: note: previous declaration of
'sys_errlist' was here
extern const char *const sys_errlist[];
^
------------------------------------------------------------------------------
Version-Release number of selected component (if applicable):
w3m-0.5.3-13.fc20.x86_64
How reproducible:
always
Steps to Reproduce:
1. enable "-Werror=format-security" flag
2. Fix the API where format specifier is needed
3. still it failed to compile with above error
Actual results:
does not compile
Expected results:
should compile
Additional info:
I found the only way to fix is remove code that checks if sys_errlist variable
is available or not on your system. We can't patch configure.ac as it needs to
use autoreconf which fails for this very old source code. So better if we have
working package by removing related code that adds function
prepare_sys_errlist() code then lets remove it by patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jN5Uomwweu&a=cc_unsubscribe