https://bugzilla.redhat.com/show_bug.cgi?id=1124070
Ryan Brown <rybrown(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-cvs?
--- Comment #8 from Ryan Brown <rybrown(a)redhat.com> ---
New Package SCM Request
=======================
Package Name: pcaro-hermit-fonts
Short Description: Hermit monospace fonts
Upstream URL: https://pcaro.es/p/hermit
Owners: ryansb
Branches: f20 f21 master
InitialCC: fonts-sig i18n-team
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9nxAxXgLqC&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1124070
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #7 from Parag AN(पराग) <panemade(a)gmail.com> ---
Thanks. Looks good now.
No. The fedora-review tool will not fail but will check such mismatch and raise
it an issue.
Package is APPROVED.
Note when you request for Package SCM request, please add InitialCC as
InitialCC: fonts-sig i18n-team
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YYbyHWPJGZ&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1124070
--- Comment #5 from Parag AN(पराग) <panemade(a)gmail.com> ---
Thanks. Few more changes I will suggest
1) We have fedora-review tool which reads the spec and srpm links. This tool
shows issue for spec file name as it will not match to what is packaged inside
srpm. You can have multiple revisions of spec along with version at your web
location but keep only one latest spec with just pcaro-hermit-fonts.spec name.
2) The upstream also uses spelling as "monospace" and not "mono-space". Please
change all such occurrences. Let rpmlint complain it as warning.
3) I think many are familiar with this way to fix DOS line endings
http://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings
4) with your recent changelog another rpmlint warning has come. When you use
character '%' in %changelog section or in any line which is a comment, always
use it as twice '%%' character.
Else looks good now.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=38dYzYMFZ4&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1124070
--- Comment #4 from Ryan Brown <rybrown(a)redhat.com> ---
Parag,
Thank you for your review, I've responded inline.
1) spec file name should not contain any version or release.
The spec file name only contains a version so I can make multiple revisions
available from my web site, the actual spec file on my local machine does not
have a version in its filename.
2) If you are not planning to add this package to EPEL6 then remove following
from spec
a) Group tag is now optional and can be removed.
Done
b) "rm -rf %{buildroot}" is not needed anymore as its done automatically by
rpmbuild
Done
c) similarly %clean section is also not needed anymore
Done
3) %prep should contain only
%setup -q
For my case %setup -cq is necessary because the upstream tarball extracts files
directly into current directory instead of extracting to a folder
4) Though there is no compilation or building of binary files happening, you
can include empty %build to let rpmlint happy
Done
5) Don't add extra empty spaces in the spec file like one you have line 59
Removed
6) I think you can if wanted keep the priority of fontconfig file to 69.
Generally 60-69 numbers are used for "generic aliases, map generic->family" and
you have the same fontconfig rule.
Done
New SRPM: http://rsb.io/pkg/hermit/pcaro-hermit-fonts-1.21-3.fc20.src.rpm
New specfile: http://rsb.io/pkg/hermit/pcaro-hermit-fonts-1.21-3.spec
Thanks very much for your feedback, let me know what you think of the changes.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lW2PvMb3ZW&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1124070
--- Comment #3 from Parag AN(पराग) <panemade(a)gmail.com> ---
Suggestions:
1) spec file name should not contain any version or release. I suppose its a
typo in the initial comment for Spec URL.
2) If you are not planning to add this package to EPEL6 then remove following
from spec
a) Group tag is now optional and can be removed.
b) "rm -rf %{buildroot}" is not needed anymore as its done automatically by
rpmbuild
c) similarly %clean section is also not needed anymore
3) %prep should contain only
%setup -q
4) Though there is no compilation or building of binary files happening, you
can include empty %build to let rpmlint happy
5) Don't add extra empty spaces in the spec file like one you have line 59
6) I think you can if wanted keep the priority of fontconfig file to 69.
Generally 60-69 numbers are used for "generic aliases, map generic->family" and
you have the same fontconfig rule.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AOhmWI56D0&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1117860
Bug ID: 1117860
Summary: Adjust Finnish keyboards
Product: Fedora
Version: 21
Component: langtable
Assignee: mfabian(a)redhat.com
Reporter: myllynen(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: i18n-bugs(a)lists.fedoraproject.org, mfabian(a)redhat.com
Description of problem:
keyboards.xml currently has the following definitions for Finnish keyboards:
<keyboard>
<keyboardId>fi</keyboardId>
<description>Finnish</description>
<ascii>True</ascii>
<languages>
<language><languageId>fi</languageId><rank>900</rank></language>
<language><languageId>sv</languageId><rank>100</rank></language>
</languages>
<territories>
<territory><territoryId>FI</territoryId><rank>1000</rank></territory>
</territories>
</keyboard>
<keyboard>
<keyboardId>fi(nodeadkeys)</keyboardId>
<description>Finnish (classic, eliminate dead keys)</description>
<ascii>True</ascii>
<languages>
<language><languageId>fi</languageId><rank>900</rank></language>
<language><languageId>sv</languageId><rank>100</rank></language>
</languages>
<territories>
<territory><territoryId>FI</territoryId><rank>1000</rank></territory>
</territories>
</keyboard>
The fi one above is the standard (kotoistus) layout most people want to use but
the second one, fi(nodeadkeys), is the dead key variant of the fi(fi) layout,
not of fi, and my guess is that there are very few people using it, if any. But
people certainly do use the fi(fi) variant which is currently not present.
See http://cgit.freedesktop.org/xkeyboard-config/tree/symbols/fi.
I think we should replace fi(nodeadkeys) with fi(fi) (description: "Finnish
(classic)") and if someone actually uses fi(nodeadkeys) and complains, we can
then always put fi(nodeadkeys) back.
Version-Release number of selected component (if applicable):
langtable-0.24
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yVjYmhxuus&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1124070
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |fonts-bugs(a)lists.fedoraproj
| |ect.org,
| |i18n-bugs(a)lists.fedoraproje
| |ct.org, panemade(a)gmail.com
Assignee|nobody(a)fedoraproject.org |panemade(a)gmail.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QSjwzH5sfW&a=cc_unsubscribe