https://bugzilla.redhat.com/show_bug.cgi?id=1526510
Bug ID: 1526510 Summary: USE_TYPO_METRICS set in Fedora 2X but not set in RHEL7 or in ttf binary release Product: Fedora Version: 27 Component: liberation-fonts Assignee: psatpute@redhat.com Reporter: caolanm@redhat.com QA Contact: extras-qa@fedoraproject.org CC: alexl@redhat.com, caillon+fedoraproject@gmail.com, caolanm@redhat.com, fonts-bugs@lists.fedoraproject.org, gnome-sig@lists.fedoraproject.org, i18n-bugs@lists.fedoraproject.org, john.j5live@gmail.com, mbarnes@fastmail.com, mclasen@redhat.com, petersen@redhat.com, psatpute@redhat.com, rhughes@redhat.com, rstrode@redhat.com, sandmann@redhat.com External Bug ID: Document Foundation 114434
Created attachment 1368567 --> https://bugzilla.redhat.com/attachment.cgi?id=1368567&action=edit fontforge os/2 metric table on Fedora for Liberation Serif Regular
Description of problem:
The USE_TYPO_METRICS fsSelection bit (https://www.microsoft.com/typography/otspec/os2.htm#fss) is set in Liberation Serif Regular (probably all of them) under Fedora >= 25 but is *not* set in the RHEL versions or in the binary releases available at http://releases.pagure.org/liberation-fonts/liberation-fonts-ttf-1.07.4.tar....
Version-Release number of selected component (if applicable): liberation-fonts-1.07.4-9.fc27
How reproducible: 100%
Steps to Reproduce: 1. (In Fedora) fontforge LiberationSerif-Regular.ttf 2. element->font info->os/2->metrics 3. Example "Really use typo metrics"
Actual results: its on
Expected results: its off
Additional info: If I rebuild the fedora rawhide package on fedora I get the bit set, if I rebuild under RHEL7 I get the bit set, so the build environment/tools matter in terms of the results
I think we want this bit off in fedora to match what we have in RHEL and in the binary releases and what I see in Arimo and Times New Roman (probably best to confirm that independently)
This matters in that in recent LibreOffice if that bit is on we use the typo metrics while if its off we use the hhea metrics and for Liberation Serif they are different enough to mangle starmath equations as per the linked bug
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
--- Comment #1 from Caolan McNamara caolanm@redhat.com --- Created attachment 1368568 --> https://bugzilla.redhat.com/attachment.cgi?id=1368568&action=edit same font, built on RHEL-7 without the bit set
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
Pravin Satpute psatpute@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|psatpute@redhat.com |petersen@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
--- Comment #2 from Pravin Satpute psatpute@redhat.com --- We are planning to rename liberation-fonts-1.07.4-9.fc27 as liberation-classic-fonts.
So i think this patch should go in https://pagure.io/liberation-classic-fonts.
May be need to check for liberation-fonts-2.00.1 as well for this.
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|petersen@redhat.com |pnemade@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
--- Comment #7 from Caolan McNamara caolanm@redhat.com --- Copy the RHEL-7 LiberationSerif-Regular.ttf to a fedora >= F25 box and open it with fontforge on that platform and the flag will be shown as unset. Using the same Fedora fontforge on the Fedora LiberationSerif-Regular.ttf will show that the flag is set in the Fedora version.
Yes, the RHEL-7 fontforge appears to claims that the bit is set, but with a hexeditor/hexdump it can be verified that the bit is not set in the RHEL LiberationSerif-Regular.ttf and is set in the Fedora LiberationSerif-Regular.ttf
i.e. the RHEL fontforge is telling fibs and the Fedora one is telling the truth.
I assume its probably a bug in RHEL-7 fontforge that OS2_UseTypoMetrics doesn't seem to set the right bit in the .ttf when the sfd is converted to ttf, and probably the same bug that the ui claims that the .ttf does have the bit set.
So I guess OS2_UseTypoMetrics handling got fixed at some point, so the bit started getting set correctly in Fedora with more recent fontforge, and I think that the (accidental) lack of the bit in RHEL (and the binary .ttf releases) matches by chance the desired state the fonts should be in
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
--- Comment #8 from Caolan McNamara caolanm@redhat.com --- maybe something like https://github.com/fontforge/fontforge/commit/e870019c2602d50eb00793e979f3e1...
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
--- Comment #9 from Parag Nemade pnemade@redhat.com --- Thank you Caolan for your brief reply.
I have now generated scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=23779983 for Fedora.
If anyone want to test it please test them, I will push the fix into the f27+ releases in next 2 days.
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- liberation-fonts-1.07.4-10.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-551b13319e
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- liberation-fonts-1.07.4-10.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-551b13319e
https://bugzilla.redhat.com/show_bug.cgi?id=1526510
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |liberation-fonts-1.07.4-10. | |fc27 Resolution|--- |ERRATA Last Closed| |2017-12-27 21:52:19
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- liberation-fonts-1.07.4-10.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
i18n-bugs@lists.fedoraproject.org