Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Package Review: ibus-table-yong
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Summary: Package Review: ibus-table-yong Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Keywords: i18n Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cchance@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, petersen@redhat.com, fedora-package-review@redhat.com, panemade@gmail.com, cchance@redhat.com, phuang@redhat.com, fedora-i18n-bugs@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Clone Of: 488173
SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090421-1.f...
Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong.spec
Description: Yong table data for IBus-Table which is an engine of IBus.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Caius 'kaio' Chance cchance@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
--- Comment #1 from Caius 'kaio' Chance cchance@redhat.com 2009-04-21 19:57:31 EDT --- SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090422-1.f...
Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong.spec
Tarball URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090422.tar...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
--- Comment #2 from Parag AN(पराग) panemade@gmail.com 2009-04-22 00:00:53 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1313840 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 3d8a91a171e16c6eac4c9c2f2b3ac218 ibus-table-yong-1.1.0.20090422.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate.
Suggestions: 1) I think its ok to drop following line from %description Erbi is released under released under GPLv3. or modify to replace Erbi to Yong 2) can you remove following %verify(not md5 size mtime) ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
--- Comment #3 from Caius 'kaio' Chance cchance@redhat.com 2009-04-22 19:51:32 EDT --- SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090422-2.f...
Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong.spec
Tarball URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090422.tar...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Parag AN(पराग) panemade@gmail.com 2009-04-22 23:49:21 EDT --- koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1316239
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
--- Comment #5 from Parag AN(पराग) panemade@gmail.com 2009-05-05 00:13:58 EDT --- can you request cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Caius 'kaio' Chance cchance@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
--- Comment #6 from Caius 'kaio' Chance cchance@redhat.com 2009-05-05 00:27:35 EDT --- requested
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |
--- Comment #7 from Jens Petersen petersen@redhat.com 2009-05-05 03:43:16 EDT --- Heh, missing Request form!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
--- Comment #8 from Caius 'kaio' Chance cchance@redhat.com 2009-05-05 12:59:08 EDT --- Package Name: ibus-table-yong Short Description: Yong table data for IBus Table Owners: cchance Branches: devel InitialCC: i18n-team
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2009-05-06 17:00:25 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Caius 'kaio' Chance cchance@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #10 from Caius 'kaio' Chance cchance@redhat.com 2009-05-06 23:32:13 EDT --- built:
http://koji.fedoraproject.org/koji/buildinfo?buildID=101156
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Caius 'kaio' Chance cchance@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #11 from Caius 'kaio' Chance cchance@redhat.com 2009-05-19 00:51:30 EDT --- SRPM URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong-1.1.0.20090422-5.f...
Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-yong.spec
Package Name: ibus-table-yong Short Description: Yong table data for IBus Table Owners: cchance Branches: F-11 InitialCC: i18n-team
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Caius 'kaio' Chance cchance@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Reopened Status|CLOSED |ASSIGNED Resolution|RAWHIDE |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
--- Comment #12 from Caius 'kaio' Chance cchance@redhat.com 2009-05-19 03:09:34 EDT --- (F-11)
SRPM URL: http://cchance.fedorapeople.org/F-11/ibus-table-yong-1.1.0.20090422-5.fc12.s...
Spec URL: http://cchance.fedorapeople.org/F-11/ibus-table-yong.spec
=====
(F-10)
SRPM URL: http://cchance.fedorapeople.org/F-10/ibus-table-yong-1.1.0.20090422-5.fc10.s...
Spec URL: http://cchance.fedorapeople.org/F-10/ibus-table-yong.spec
=====
Package Name: ibus-table-yong Short Description: Yong table data for IBus Table Owners: cchance Branches: F-10, F-11 InitialCC: i18n-team
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
--- Comment #13 from Caius 'kaio' Chance cchance@redhat.com 2009-05-19 03:15:06 EDT --- (F-11)
SRPM URL: http://cchance.fedorapeople.org/rpms/F-11/ibus-table-yong-1.1.0.20090422-5.f...
Spec URL: http://cchance.fedorapeople.org/rpms/F-11/ibus-table-yong.spec
=====
(F-10)
SRPM URL: http://cchance.fedorapeople.org/rpms/F-10/ibus-table-yong-1.1.0.20090422-5.f...
Spec URL: http://cchance.fedorapeople.org/rpms/F-10/ibus-table-yong.spec
=====
Package Name: ibus-table-yong Short Description: Yong table data for IBus Table Owners: cchance Branches: F-10, F-11 InitialCC: i18n-team
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Caius 'kaio' Chance cchance@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #14 from Caius 'kaio' Chance cchance@redhat.com 2009-05-19 20:33:16 EDT --- Package Change Request ====================== Package Name: ibus-table-yong New Branches: F-10, F-11 Owners: cchance
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #15 from Kevin Fenzi kevin@tummy.com 2009-05-20 01:44:49 EDT --- cvs done.
i18n-bugs@lists.fedoraproject.org