[Fedora-i18n-bugs] [Bug 810211] New: The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: The key events with ctrl key isn't delivered during the switcher window is open

https://bugzilla.redhat.com/show_bug.cgi?id=810211

Summary: The key events with ctrl key isn't delivered during
                    the switcher window is open
           Product: Fedora
           Version: 17
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: ibus
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: Bug
        Regression: ---
        Mount Type: ---
     Documentation: ---

Description of problem:
The switcher window is open when ctrl+space is pressed and keep it open until
the ctrl key is released. this behavior is introduced since f17 though, the key
combination with ctrl key could be sent to application without releasing the
ctrl key in older releases. e.g. one may wants to move the cursor with ctrl+a
and ctrl+e after turn off ibus. on f16 or older version, it could be done by
the following sequences: ctrl+space (to turn off) -> ctrl+a (to move the cursor
at the beginning of line) but on f17: ctrl+space -> release the ctrl key ->
ctrl+a. need an extra step to accomplish it.  So that would be nice if we can
keep the old behavior on f17 too.

As we talked on IRC, I don't mind whether keep the switcher window open or not.
if it's easier to do it after closing, that's fine.

Version-Release number of selected component (if applicable):
ibus-1.4.99.20120317-2.fc17.x86_64

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #1 from fujiwara  2012-04-24 06:09:44 EDT ---
gdk_event_handler_set() calls the callback for the keybinding only which is
assigned in XIGrabKeycode() in XI2.
So I think if you press ctrl+a, the callback is not called and probably it
might be hard to fix this.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #2 from fujiwara  2012-05-09 06:43:26 EDT ---
Created attachment 583209
  --> https://bugzilla.redhat.com/attachment.cgi?id=583209
Patch1 for upstream

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #3 from fujiwara  2012-05-09 06:44:20 EDT ---
Created attachment 583210
  --> https://bugzilla.redhat.com/attachment.cgi?id=583210
Patch2 for customizable Control+space

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_DEV

--- Comment #4 from fujiwara  2012-05-09 06:47:57 EDT ---
For ibus-gjs:
https://github.com/fujiwarat/ibus-gjs/commit/58753582f50a030f57b34e6f06071c3...

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #5 from Peng Huang  2012-05-15 12:00:23 EDT ---
This is an intended behavior. It is like window switcher dialog of gnome3:
(After Alt+Tab, without release Alt key, user may press arrow keys for
navigating focus between windows.)
And in future, we can also add following logic:

1. Ctrl + Space (to fire the ime switch window)
2. Letter to (navigate focus between IME which names start with letter user
pressed and etc)
3. Release Ctrl, do the real IME switch.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #6 from Akira TAGOH  2012-05-15 22:08:07 EDT ---
The requirements is different between the focus change and the IME change. no
one expects to have any operations on originally-focused window
with/during/after the focus change anymore. but not on the IME change. having
same behavior regardless of it makes no sense at all.

This is actually a bigger regression and affects the usability. it's not
completely accepted.

For the future plan, I'm not quite sure what you are trying to address but I
don't think it's worth implementing by giving up the usability and the existing
features. I'm also wondering how often one changes among IMEs. in most cases,
they should have only two (the keyboard layout thing and IME for their native
language).

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #7 from fujiwara  2012-05-15 22:59:38 EDT ---
(In reply to comment #5)
> This is an intended behavior. It is like window switcher dialog of gnome3:

I think yourself only intend it.
This is a regression bug and we believe this should be fixed.

You don't have to try gnome-shell. The behavior should be owned by ibus-gjs.
I think the GTK based ibus should have the similar behavior with metacity.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #8 from Peng Huang  2012-05-16 10:11:49 EDT ---
When I implemented this logic in ibus, I followed behavior of gnome2 (compiz
WM) and gnome3 Window switcher dialog (I din't try KDE).

Anyway I respect your decision. Just want to let your guys know why I did it.
And I also think it is hard to fix, because the following key events are
already consumed by IME switcher dialog. You have to do some dirty hacks to
change current behavior.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #9 from Akira TAGOH  2012-05-16 21:52:35 EDT ---
Thanks for the comment. what I was saying on this is,  no matter what desktops
you were referring to implement this feature, having same behavior with the
window switcher that is supposed to change the focus is wrong for IME switch.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #10 from fujiwara  2012-05-17 06:26:56 EDT ---
(In reply to comment #5)
> Ctrl + Space (to fire the ime switch window)
> Letter to (navigate focus between IME which names start with letter user
>
> pressed and etc)
> 3. Release Ctrl, do the real IME switch.

Probably I think it's an idea to replace this with engine hotkeys or Contrl+[1,
2, 3....]

(In reply to comment #8)
> When I implemented this logic in ibus, I followed behavior of gnome2 (compiz
> WM) and gnome3 Window switcher dialog (I din't try KDE).

compiz-gnome is no longer available in Fedora 17.
> Anyway I respect your decision. Just want to let your guys know why I did it.
> And I also think it is hard to fix, because the following key events are
> already consumed by IME switcher dialog. You have to do some dirty hacks to
> change current behavior.

I already provide the patch and it's enough for me.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_DEV                      |MODIFIED

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #11 from Fedora Update System  2012-05-18 06:53:17 EDT ---
ibus-1.4.99.20120428-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/ibus-1.4.99.20120428-2.fc17

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=810211

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #12 from Fedora Update System  2012-05-18 16:25:32 EDT ---
Package ibus-1.4.99.20120428-2.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ibus-1.4.99.20120428-2.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-8084/ibus-1.4.99.2012042...
then log in and leave karma (feedback).

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #13 from Akira TAGOH  ---
Is it possible to resend the key event after canceling the switcher? I think
the updates improves this issue a bit but there are still a regression.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #14 from fujiwara  ---
(In reply to comment #13)
> Is it possible to resend the key event after canceling the switcher? I think
> the updates improves this issue a bit but there are still a regression.

I thought we agreed it's no problem whether the key event cancel the switcher
or it's sent to the client applications.

I think resending the event won't work since ibus panel works outside the
applications and the GdkEvent does not include the focused GdkWindow.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2012-05-29 06:31:42

--- Comment #15 from Fedora Update System  ---
ibus-1.4.99.20120428-2.fc17 has been pushed to the Fedora 17 stable repository.
 If problems still persist, please make note of it in this bug report.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #16 from Akira TAGOH  ---
On GNOME 3.6 integreated the input source, the behavior has been back as it did
previously, which is ideal. that would means it may gives different UX among
desktops. so I'm wondering if we should keeps this UI yet.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #17 from fujiwara  ---
(In reply to comment #16)
> On GNOME 3.6 integreated the input source, the behavior has been back as it
> did previously, which is ideal. that would means it may gives different UX
> among desktops. so I'm wondering if we should keeps this UI yet.

GNOME has the plan to implement the similar UI.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #18 from Akira TAGOH  ---
You mean upstream is about to follow up to make a regression?

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #19 from fujiwara  ---
(In reply to comment #18)
> You mean upstream is about to follow up to make a regression?

No, I mean the switcher UI only.
If GNOME will have the better event handling, probably I can compare the
behavior.
But currently I have no way to get GDK windows with XI2.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #20 from Akira TAGOH  ---
No? in fact that UI eats the key events. it's a regression anyway.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #21 from fujiwara  ---
OK, I thought we agreed it's no problem whether the key event cancel the
switcher or it's sent to the client applications in our initial discussion.

(In reply to comment #0)
> As we talked on IRC, I don't mind whether keep the switcher window open or
> not. if it's easier to do it after closing, that's fine.

Probably I didn't get your request.
I will investigate the comment #56 in bug 756595 but I'm not sure if it can
resolve your problem.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #22 from Akira TAGOH  ---
(In reply to comment #21)
> (In reply to comment #0)
> > As we talked on IRC, I don't mind whether keep the switcher window open or
> > not. if it's easier to do it after closing, that's fine.
>
> Probably I didn't get your request.
> I will investigate the comment #56 in bug 756595 but I'm not sure if it can
> resolve your problem.

Please read the summary again... it's all of my compliant. the above quote was
to mention about the status of the switcher window. if you want to keep it
during holding the ctrl key, I don't mind as long as the non-handled key events
in ibus it surely delivered to the application, if it's easier to do it rather
than closing.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

--- Comment #23 from fujiwara  ---
(In reply to comment #22)
> (In reply to comment #21)
> > (In reply to comment #0)
> > > As we talked on IRC, I don't mind whether keep the switcher window open or
> > > not. if it's easier to do it after closing, that's fine.
> >
> > Probably I didn't get your request.
> > I will investigate the comment #56 in bug 756595 but I'm not sure if it can
> > resolve your problem.
>
> Please read the summary again... it's all of my compliant. the above quote

I know it but I meant the initial discussion before you filed this.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?([e-mail])

--- Comment #24 from fujiwara  ---
I'd ask if the delivering the key events is still needed.
Currently the trigger key is Super+space and I guess other keys likes Super+a
is not so important.
Probably I think you could assign Ctrl+space as an engine shortcut key instead.
Also GNOME switcher also has the same behavior.

If the feature is no longer needed, I will delete the internal patch.
The current internal patch just cancels Super+space.

[Fedora-i18n-bugs] [Bug 810211] The key events with ctrl key isn't delivered during the switcher window is open

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=810211

Akira TAGOH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail]) |