Re: [fedora-india] Testing required for menumaker RPM
Hi,
--- On Mon, Jun 1, 2009 at 1:06 AM, Gireesh Sreekantan
<sgireeshmail(a)gmail.com> wrote:
| This being my *first ever* rpm package,
\--
Congratulations! The first step is always the toughest.
---
| I don't expect it to be 100%
| correct. I would gladly welcome feedback.
\--
#01 Source0 should point to a URL from the project page so anyone
could download it from the source and verify it. For example:
Source0:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
#02 "BuildRequires: gcc" need not be mentioned because it is included
by default. See:
http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
#03 You need to put your e-mail address in the %changelog, along with
the version number. You have two %changelog entries! Put the
%changelog at the end. For example:
%changelog
* Fri May 15 2009 Gireesh <sgireeshmail [AT] gmail DOT com> - 0.99-1
- updated spec file
- bumped version minor number
0.99 is the Version and 1 is the .spec file version. Since you have
already publicized your .spec, and if you make further changes to your
.spec file, please increment the .spec file version number.
#04 In %files section, I am not sure if you want to put all under
/usr/bin/*, and /usr/lib/*. Just choose the files that are to be
packaged and use the macros -- %{_bindir}, %{_sbindir}. The same
applies to %doc /usr/share/info/mmaker.info.gz.
#05 You also need to run rpmlint on .spec, and the built .src.rpm, and .rpm.
I see there are some warnings and errors for the .spec file. Please fix them.
$ rpmlint menumaker.spec
menumaker.spec:6: W: non-standard-group Applications/Utilities
menumaker.spec:42: E: hardcoded-library-path in /usr/lib/*
menumaker.spec: W: more-than-one-%changelog-section
0 packages and 1 specfiles checked; 1 errors, 2 warnings.
#06 Because it is Python interpreted code, you also need to put
"BuildArch: noarch" (say, after BuildRoot) in the .spec file.
#07 Also checkout Python RPM guildelines on howto package Python modules.
https://fedoraproject.org/wiki/Packaging/Python
https://fedoraproject.org/wiki/Packaging/Python/Eggs
I have actually updated Packaging-RPM with these minor details. Please
use the latest 1.5 version, if you using it for reference.
http://shakthimaan.com/downloads/glv/presentations/packaging-red-hot-pane...
Regards,
SK
--
Shakthi Kannan
http://www.shakthimaan.com