+1 from me

On Mar 9, 2015 12:02 PM, "David Gay" <dgay@redhat.com> wrote:


----- Original Message -----
> From: "Ralph Bean" <rbean@redhat.com>
> To: infrastructure@lists.fedoraproject.org
> Sent: Monday, March 9, 2015 10:59:54 AM
> Subject: Freeze Break Request:  Add more fedmsg endpoints for fedimg
>
>
> The fedimg uploader daemon that uploads cloud images to AWS is
> complaining that it doesn't have enough fedmsg endpoints.
>
> It needs an endpoint for each worker thread, one for the parent thread, and
> then twice that number so that the daemon can do work while an admin can run
> the commands by hand at the same time (otherwise, the daemon claims all the
> ports and the manual commands fail).
>
> Can I get two +1s to apply this and push it out to all our hosts?
>
>
> diff --git a/roles/fedmsg/base/templates/endpoints-fedimg.py.j2
> b/roles/fedmsg/base/templates/endpoints-fedimg.py.j2
> index b13f3a7..5a4fb9d 100644
> --- a/roles/fedmsg/base/templates/endpoints-fedimg.py.j2
> +++ b/roles/fedmsg/base/templates/endpoints-fedimg.py.j2
> @@ -4,11 +4,15 @@ suffix  = 'stg.phx2.fedoraproject.org'
>  suffix = 'phx2.fedoraproject.org'
>  {% endif %}
>
> +primary_threads = 4
> +atomic_threads = 2
> +NUM_FEDIMG_PORTS = 2 * ((primary_threads + atomic_threads) + 1)
> +
>  config = dict(
>      endpoints={
>          "fedimg.fedimg01": [
>              "tcp://fedimg01.%s:30%0.2i" % (suffix, i)
> -            for i in range(4)
> +            for i in range(NUM_FEDIMG_PORTS)
>          ],
>      },
>  )
>
> _______________________________________________
> infrastructure mailing list
> infrastructure@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/infrastructure

+1 from me
_______________________________________________
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure