This change is for staging only, so I'm not convinced a FBR is needed.
But here is my review anyway.
1. you added host vars for
osbs-aarch64-node01.stg.arm.fedoraproject.org, but this host is not in
inventory
2. kickstart file kvm-fedora-aarch64-28-osbs does not exist
3. You set osbs_odcs_enabled to true, but ODCS does not support aarch64
AFAIR (it works on x86_64 only I think)
4. playbooks/groups/osbs-cluster.yml should probably be updated to to
provision newly added hosts
It looks that some changes are needed for this to work.
On 08/30/2018 10:50 PM, Stephen John Smoogen wrote:
Third time is supposedly the charm they say
On Thu, 30 Aug 2018 at 16:42, Dennis Gilmore <dennis(a)ausil.us> wrote:
>
> +1 also thanks
> El jue, 30-08-2018 a las 16:23 -0400, Stephen John Smoogen escribió:
>> Talked with cverna on IRC and made changes from that. Please review
>> this one.
>> On Thu, 30 Aug 2018 at 14:48, Stephen John Smoogen <smooge(a)gmail.com>
>> wrote:
>>>
>>> This needs review by both infrastructure and people who are
>>> familiar
>>> with osbs. I am mostly copya pasta editing here so it may or may
>>> not
>>> work. It is also not clear if we need both a master and a node or
>>> just
>>> a master.
>>>
>>>
>>> --
>>> Stephen J Smoogen.
>>
>>
>>
>> _______________________________________________
>> infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
>> To unsubscribe send an email to
>> infrastructure-leave(a)lists.fedoraproject.org
>> Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
>> List Guidelines:
>>
https://fedoraproject.org/wiki/Mailing_list_guidelines
>> List Archives:
>>
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedora...
> _______________________________________________
> infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedora...
_______________________________________________
infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
To unsubscribe send an email to infrastructure-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedora...
--
Mikolaj Izdebski
Senior Software Engineer, Red Hat
IRC: mizdebsk