Thanks again for the coaching and feedback!

On 09/24/2018 07:49 AM, Zach Villers wrote:

Happy Monday all. Here's an updated set of patches for issue 7158, with
some of Kevin's comments on my previous attempt for context;

Looks good to me. :) I've committed it and am doing an ansible run now.

I had to make some very small tweaks that If I was smarter I would have
caught before pushing it:

* public_ip wasn't set for people02, so I switched it to use eth0_ip
* The path to the certs was fine if we were directly using letsencrypt,
but we don't put them in the same places on machines, so tweaked that.
* You had the certgetter url using https... but it needs to be http for
those.

Anyhow, those were all super small/slight, and everything else worked
wonderfully!

Thank you a ton for working on this...

kevin

_______________________________________________
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org