Re: State of the Review Server (Fresque)
>>>> "AB" == Aurelien Bompard
<abompard(a)fedoraproject.org> writes:
AB> My questions are: should we drop it? Rework it? How high a priority
AB> is it really?
Well, I think we would really use... something. The current bugzilla
based "experience" is basically a mess we've all learned to work around
(or given up on) and I still feel bad for new contributors who have to
struggle with it. But really, the whole process needs an overhaul and
something that simply codifies the existing process probably isn't the
best way to spend your free time.
A workflow built around pagure and various other pieces of
infrastructure like copr and taskotron which could give some measure of
automatic builds and error checking would be incredibly great but I have
no idea how possible it is.
Then we'd just say "package submissions go into this namespace in pagure
and get hooked up to automated builds and tests and whatnot". Add a way
for prospective reviewers to see those submissions and some mechanism
for a reviewer (with privileges) to approve a package for inclusion.
Then it's just a simple matter of figuring out how to get the approved
package into the distribution.
But again, I have no idea if any of this is actually possible. I do
know I'd be able to do a heck of a lot more reviewing work than I do now
(which is basically zero) if I could so things like:
* Click through a pagure listing that shows me just the package which
are actually building and ready for review
* See everything right there, including a spec file, current rpmlint
output and things like taskotron checks
* Make quick comments on the spec file
* Star a repo so it shows up in the list of packages I did review work
on (so I don't forget)
And a whole lot of that seems to be a mashup of what pagure and copr
already seem to do. Anything that encourages drive-by reviewing and
incremental improvement of submitted packages while hiding packages
which aren't at the point of building properly is a huge plus in my
opinion.
- J<