On 10/02/2018 02:22 AM, David Shier wrote:
Could someone please review the attached patch file for the removal of
tagger and statscache from the ansible repos/proxy lists/ etc.? I was
going to attach to issue, but pagure is only letting me do pictures, and
this one is large and gnarly as a picture.
1. Commit subject is way too long and not well formed. There are many
guidelines on writing commit messages, eg. 
2. Ideally there should be one service removed per commit, not both in a
3. You missed multiple references to tagger, see "git grep tagger"
infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
To unsubscribe send an email to infrastructure-leave(a)lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
Senior Software Engineer, Red Hat