On 10/02/2018 02:22 AM, David Shier wrote:

All/sysadmin-main - Could someone please review the attached patch file for the removal of tagger and statscache from the ansible repos/proxy lists/ etc.? I was going to attach to issue, but pagure is only letting me do pictures, and this one is large and gnarly as a picture.

1. Commit subject is way too long and not well formed. There are many guidelines on writing commit messages, eg. [1] 2. Ideally there should be one service removed per commit, not both in a single commit 3. You missed multiple references to tagger, see "git grep tagger" [1] https://chris.beams.io/posts/git-commit/

Thanks, Dave Shier/odin _______________________________________________ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

--

Mikolaj Izdebski Senior Software Engineer, Red Hat IRC: mizdebsk _______________________________________________ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org