[Change Request] Don't try to restart iscsi{,d}

[Ricky Zhou]

In light of what I just did to xen15, I'd like to make this change so
that puppet never makes the same mistake :-)

---
 modules/iscsi-initiator-utils/manifests/init.pp |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/modules/iscsi-initiator-utils/manifests/init.pp
b/modules/iscsi-initiator-utils/manifests/init.pp
index 4fbd54c..193b377 100644
--- a/modules/iscsi-initiator-utils/manifests/init.pp
+++ b/modules/iscsi-initiator-utils/manifests/init.pp
@@ -33,7 +33,9 @@ class iscsi-initiator-utils::initiator {
     file { '/etc/iscsi/initiatorname.iscsi':
         content =>
template("iscsi-initiator-utils/initiatorname.iscsi.erb"),
         require => Package['iscsi-initiator-utils'],
-        notify => [Service['iscsi'], Service['iscsid']],
+        # Never, ever notify this service - do any restarts manually
+        # after making sure that nothing is using a disk on iscsi.
+        #notify => [Service['iscsi'], Service['iscsid']],
     }
 }
 
-- 
1.5.5.6

[Stephen John Smoogen]

+1 to make this change. Things are screwey enought right now wihtout
it accidently doing it .

On Tue, Aug 11, 2009 at 9:56 PM, Ricky Zhou<ricky(a)fedoraproject.org> wrote:
>  In light of what I just did to xen15, I'd like to make this
> change so
>  that puppet never makes the same mistake :-)
>
>  ---
>   modules/iscsi-initiator-utils/manifests/init.pp |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
>  diff --git a/modules/iscsi-initiator-utils/manifests/init.pp
> b/modules/iscsi-initiator-utils/manifests/init.pp
>  index 4fbd54c..193b377 100644
>  --- a/modules/iscsi-initiator-utils/manifests/init.pp
>  +++ b/modules/iscsi-initiator-utils/manifests/init.pp
>  @@ -33,7 +33,9 @@ class iscsi-initiator-utils::initiator {
>      file { '/etc/iscsi/initiatorname.iscsi':
>          content =>
> template("iscsi-initiator-utils/initiatorname.iscsi.erb"),
>          require => Package['iscsi-initiator-utils'],
>  -        notify => [Service['iscsi'], Service['iscsid']],
>  +        # Never, ever notify this service - do any restarts manually
>  +        # after making sure that nothing is using a disk on iscsi.
>  +        #notify => [Service['iscsi'], Service['iscsid']],
>      }
>   }
>
>  --
>  1.5.5.6
>
>
>  _______________________________________________
>  Fedora-infrastructure-list mailing list
>  Fedora-infrastructure-list(a)redhat.com
>  https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
>
>  


-- 
Stephen J Smoogen.

Ah, but a man's reach should exceed his grasp. Or what's a heaven for?
-- Robert Browning

[Toshio Kuratomi]

On 08/11/2009 09:09 PM, Stephen John Smoogen wrote:
>  +1 to make this change. Things are screwey enought right now wihtout
>  it accidently doing it .
>   
+1

-Toshio

>  On Tue, Aug 11, 2009 at 9:56 PM, Ricky
> Zhou<ricky(a)fedoraproject.org> wrote:
> > In light of what I just did to xen15, I'd like to make this change so
> > that puppet never makes the same mistake :-)
> >
> > ---
> >  modules/iscsi-initiator-utils/manifests/init.pp |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/modules/iscsi-initiator-utils/manifests/init.pp
> b/modules/iscsi-initiator-utils/manifests/init.pp
> > index 4fbd54c..193b377 100644
> > --- a/modules/iscsi-initiator-utils/manifests/init.pp
> > +++ b/modules/iscsi-initiator-utils/manifests/init.pp
> > @@ -33,7 +33,9 @@ class iscsi-initiator-utils::initiator {
> >     file { '/etc/iscsi/initiatorname.iscsi':
> >         content =>
> template("iscsi-initiator-utils/initiatorname.iscsi.erb"),
> >         require => Package['iscsi-initiator-utils'],
> > -        notify => [Service['iscsi'], Service['iscsid']],
> > +        # Never, ever notify this service - do any restarts manually
> > +        # after making sure that nothing is using a disk on iscsi.
> > +        #notify => [Service['iscsi'], Service['iscsid']],
> >     }
> >  }
> >
> > --
> > 1.5.5.6
> >
> >
> > _______________________________________________
> > Fedora-infrastructure-list mailing list
> > Fedora-infrastructure-list(a)redhat.com
> > https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
> >
> >
>  
>  
>

[Change Request] Move Fedora Community's beaker session secret

[Luke Macken]

Trivial change,

I would like to move Fedora Community's beaker.session.secret into our
passwords git module (and change it, of course).

    --- a/modules/fedoracommunity/templates/fedoracommunity-prod.ini.erb
    +++ b/modules/fedoracommunity/templates/fedoracommunity-prod.ini.erb
    @@ -117,7 +117,7 @@ full_stack = true
     #lang = ru
     #cache_dir = /var/cache/fedoracommunity/data
     beaker.session.key = fedoracommunity
    -beaker.session.secret = ?
    +beaker.session.secret = <%= fcommBeakerSessionSecret %>

     beaker.cache.type = ext:memcached
     beaker.cache.url = memcached1;memcached2

[Change Request] Move Fedora Community's beaker session secret

[Toshio Kuratomi]

On 08/12/2009 11:10 AM, Luke Macken wrote:
>  Trivial change,
>  
>  I would like to move Fedora Community's beaker.session.secret into our
>  passwords git module (and change it, of course).
>  
>      --- a/modules/fedoracommunity/templates/fedoracommunity-prod.ini.erb
>      +++ b/modules/fedoracommunity/templates/fedoracommunity-prod.ini.erb
>      @@ -117,7 +117,7 @@ full_stack = true
>       #lang = ru
>       #cache_dir = /var/cache/fedoracommunity/data
>       beaker.session.key = fedoracommunity
>      -beaker.session.secret = ?
>      +beaker.session.secret = <%= fcommBeakerSessionSecret %>
>  
>       beaker.cache.type = ext:memcached
>       beaker.cache.url = memcached1;memcached2
>   
+1

-Toshio

[Change Request] Move Fedora Community's beaker session secret

[Ricky Zhou]

On 2009-08-12 02:10:54 PM, Luke Macken wrote:
>  Trivial change,
>  
>  I would like to move Fedora Community's beaker.session.secret into our
>  passwords git module (and change it, of course). 
+1

Thanks,
Ricky

[Change Request] Move Fedora Community's beaker session secret

[Darren VanBuren]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Aug 12, 2009, at 11:10 AM, Luke Macken wrote:

>  Trivial change,
>
>  I would like to move Fedora Community's beaker.session.secret into our
>  passwords git module (and change it, of course).
>
>     --- a/modules/fedoracommunity/templates/fedoracommunity- 
>  prod.ini.erb
>     +++ b/modules/fedoracommunity/templates/fedoracommunity- 
>  prod.ini.erb
>     @@ -117,7 +117,7 @@ full_stack = true
>      #lang = ru
>      #cache_dir = /var/cache/fedoracommunity/data
>      beaker.session.key = fedoracommunity
>     -beaker.session.secret = ?
>     +beaker.session.secret = <%= fcommBeakerSessionSecret %>
>
>      beaker.cache.type = ext:memcached
>      beaker.cache.url = memcached1;memcached2 
+1, if I were a sysadmin-main person.

Darren VanBuren
onekopaka(a)gmail.com
====================
http://oks.verymad.net/

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (Darwin)
>
> iEYEARECAAYFAkqDBzwACgkQBkMMSWb0YpbTNACfdyYR7Uol/oA+hPtuO5ywvaqo
> 8NoAoI3htjeghQc0A0mWCgs04xPo11LD
> =dkgV
> -----END PGP SIGNATURE-----