Freeze break: pkgs git config

[Kevin Fenzi]

Greetings.

It seems there is a fedpkg/pyrpgk update that depends on using the
namespaced (/rpms/) git checkouts.

I'd like to apply the following to pkgs02:

diff --git a/inventory/group_vars/pkgs b/inventory/group_vars/pkgs
index 2ebef26..fa29449 100644
--- a/inventory/group_vars/pkgs
+++ b/inventory/group_vars/pkgs
@@ -18,7 +18,7 @@ git_group: packager
 git_port: 9418
 git_server: /usr/libexec/git-core/git-daemon
 git_server_args: --export-all --syslog --inetd --verbose
-git_basepath: /srv/git/repositories/rpms
+git_basepath: /srv/git/repositories
 git_daemon_user: nobody

clamscan_mailto: [e-mail]

and then make sure we are using the systemd git socket instead of
xinetd (which we seem to be for some reason currently).

This should allow namespaced git checkouts and fix:

https://fedorahosted.org/fedora-infrastructure/ticket/5178
and
https://fedorahosted.org/fedora-infrastructure/ticket/5059

I also have already made this change in stg a while back and it works
fine there.

+1s?

kevin

[Ralph Bean]

On Sun, Mar 20, 2016 at 04:38:40PM -0600, Kevin Fenzi wrote:
> Greetings.
>
> It seems there is a fedpkg/pyrpgk update that depends on using the
> namespaced (/rpms/) git checkouts.
>
> I'd like to apply the following to pkgs02:
>
> diff --git a/inventory/group_vars/pkgs b/inventory/group_vars/pkgs
> index 2ebef26..fa29449 100644
> --- a/inventory/group_vars/pkgs
> +++ b/inventory/group_vars/pkgs
> @@ -18,7 +18,7 @@ git_group: packager
>  git_port: 9418
>  git_server: /usr/libexec/git-core/git-daemon
>  git_server_args: --export-all --syslog --inetd --verbose
> -git_basepath: /srv/git/repositories/rpms
> +git_basepath: /srv/git/repositories
>  git_daemon_user: nobody
>
> clamscan_mailto: [e-mail]
>
> and then make sure we are using the systemd git socket instead of
> xinetd (which we seem to be for some reason currently).
>
> This should allow namespaced git checkouts and fix:
>
> https://fedorahosted.org/fedora-infrastructure/ticket/5178
> and
> https://fedorahosted.org/fedora-infrastructure/ticket/5059
>
> I also have already made this change in stg a while back and it works
> fine there.

+1 here

[Pierre-Yves Chibon]

On Sun, Mar 20, 2016 at 04:38:40PM -0600, Kevin Fenzi wrote:
> Greetings.
>
> It seems there is a fedpkg/pyrpgk update that depends on using the
> namespaced (/rpms/) git checkouts.
>
> I'd like to apply the following to pkgs02:
>
> diff --git a/inventory/group_vars/pkgs b/inventory/group_vars/pkgs
> index 2ebef26..fa29449 100644
> --- a/inventory/group_vars/pkgs
> +++ b/inventory/group_vars/pkgs
> @@ -18,7 +18,7 @@ git_group: packager
>  git_port: 9418
>  git_server: /usr/libexec/git-core/git-daemon
>  git_server_args: --export-all --syslog --inetd --verbose
> -git_basepath: /srv/git/repositories/rpms
> +git_basepath: /srv/git/repositories
>  git_daemon_user: nobody
>
> clamscan_mailto: [e-mail]
>
> and then make sure we are using the systemd git socket instead of
> xinetd (which we seem to be for some reason currently).
>
> This should allow namespaced git checkouts and fix:
>
> https://fedorahosted.org/fedora-infrastructure/ticket/5178
> and
> https://fedorahosted.org/fedora-infrastructure/ticket/5059
>
> I also have already made this change in stg a while back and it works
> fine there.
>
> +1s?

+1 easy enough to revert

Pierre

[Kevin Fenzi]

Sadly, while this change fixes new fedpkg/pyrpkg, it breaks old fedpkg.

I have reverted it for now and Ralph and Pingou are looking for a
better solution.

kevin

[Ralph Bean]

On Mon, Mar 21, 2016 at 09:31:57AM -0600, Kevin Fenzi wrote:
> Sadly, while this change fixes new fedpkg/pyrpkg, it breaks old fedpkg.
>
> I have reverted it for now and Ralph and Pingou are looking for a
> better solution.

It was fun.  We read the C code for git-daemon and ultimately resolved it
as a problem with our selinux policy.  We fixed that and re-rolled out
Kevin's original change.  Should be all working in prod now.